fix: require approval before skill workshop apply

pgondhi987 · pgondhi987 · commit 7058983ba077 · 2026-05-07T06:34:24.000Z
diff --git a/docs/plugins/skill-workshop.md b/docs/plugins/skill-workshop.md
@@ -420,6 +420,9 @@ the `apply` action after approval.
 
 Apply a pending proposal.
 
+With `approvalPolicy: "pending"`, this action asks for operator approval before writing the
+workspace skill.
+
 ```json
 {
   "action": "apply",
diff --git a/extensions/skill-workshop/index.test.ts b/extensions/skill-workshop/index.test.ts
@@ -2,6 +2,7 @@ import fs from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
 import type { AnyAgentTool } from "openclaw/plugin-sdk/agent-runtime";
+import type { PluginTrustedToolPolicyRegistration } from "openclaw/plugin-sdk/core";
 import { createTestPluginApi } from "openclaw/plugin-sdk/plugin-test-api";
 import { afterEach, describe, expect, it, vi } from "vitest";
 import plugin, {
@@ -657,18 +658,30 @@ describe("skill-workshop", () => {
     const store = new SkillWorkshopStore({ stateDir, workspaceDir });
     expect(await store.list("pending")).toHaveLength(1);
     expect(await store.list("applied")).toHaveLength(0);
+  });
 
-    const applied = await tool?.execute?.("call-2", {
-      action: "apply",
-      id: proposalId,
+  it("requires operator approval before applying queued proposals in pending mode", async () => {
+    let trustedPolicy: PluginTrustedToolPolicyRegistration | undefined;
+    const api = createTestPluginApi({
+      pluginConfig: { approvalPolicy: "pending" },
+      registerTrustedToolPolicy(policy) {
+        trustedPolicy = policy;
+      },
     });
 
-    expect(applied?.details).toMatchObject({ status: "applied" });
-    await expect(
-      fs.access(path.join(workspaceDir, "skills", "screenshot-asset-workflow", "SKILL.md")),
-    ).resolves.toBeUndefined();
-    expect(await store.list("pending")).toHaveLength(0);
-    expect(await store.list("applied")).toHaveLength(1);
+    plugin.register(api);
+
+    const result = await trustedPolicy?.evaluate(
+      { toolName: "skill_workshop", params: { action: "apply", id: "proposal-1" } },
+      { toolName: "skill_workshop" },
+    );
+
+    expect(result).toMatchObject({
+      requireApproval: {
+        title: "Apply workspace skill proposal",
+        allowedDecisions: ["allow-once", "deny"],
+      },
+    });
   });
 
   it("uses the reviewer to propose existing skill repairs", async () => {
diff --git a/extensions/skill-workshop/index.ts b/extensions/skill-workshop/index.ts
@@ -38,6 +38,30 @@ export default definePluginEntry({
       },
     );
 
+    api.registerTrustedToolPolicy({
+      id: "skill-workshop-apply-approval",
+      description: "Require operator approval before applying queued workspace skill proposals.",
+      evaluate(event) {
+        const config = resolveCurrentConfig();
+        if (
+          !config.enabled ||
+          config.approvalPolicy === "auto" ||
+          event.toolName !== "skill_workshop" ||
+          event.params.action !== "apply"
+        ) {
+          return undefined;
+        }
+        return {
+          requireApproval: {
+            title: "Apply workspace skill proposal",
+            description: "Apply a queued workspace skill proposal.",
+            severity: "warning",
+            allowedDecisions: ["allow-once", "deny"],
+          },
+        };
+      },
+    });
+
     api.on("before_prompt_build", async () => {
       const config = resolveCurrentConfig();
       if (!config.enabled) {

Original file line number	Diff line number	Diff line change
@@ -420,6 +420,9 @@ the `apply` action after approval.
`420`	`420`
`421`	`421`	`Apply a pending proposal.`
`422`	`422`
	`423`	+With `approvalPolicy: "pending"`, this action asks for operator approval before writing the
	`424`	`+workspace skill.`
	`425`	`+`
`423`	`426`	```json
`424`	`427`	`{`
`425`	`428`	`"action": "apply",`