fix(slack): strip dispatcher option before passing to globalThis.fetch

arbaleast · arbaleast · commit 7016fcf0fdeb · 2026-04-09T06:12:27.000+08:00
In Node.js v25, globalThis.fetch does not support the dispatcher option
(only undici.fetch does). Strip dispatcher from init options while routing
dispatcher-backed requests through fetchWithRuntimeDispatcher (undici.fetch).
Fixes silent download-file failures on Node.js v25.
diff --git a/extensions/slack/src/monitor/media.ts b/extensions/slack/src/monitor/media.ts
@@ -77,11 +77,12 @@ function createSlackMediaFetch(): FetchLike {
       throw new Error("Unsupported fetch input: expected string, URL, or Request");
     }
     const parsed = assertSlackFileUrl(url);
+    const { dispatcher: _dispatcher, redirect: _redirect, ...rest } = init ?? {};
     const fetchImpl =
-      "dispatcher" in (init ?? {}) && !isMockedFetch(globalThis.fetch)
+      _dispatcher !== undefined && !isMockedFetch(globalThis.fetch)
         ? fetchWithRuntimeDispatcher
         : globalThis.fetch;
-    return fetchImpl(parsed.href, { ...init, redirect: "manual" });
+    return fetchImpl(parsed.href, { ...rest, redirect: "manual" });
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -77,11 +77,12 @@ function createSlackMediaFetch(): FetchLike {`
`77`	`77`	`throw new Error("Unsupported fetch input: expected string, URL, or Request");`
`78`	`78`	`}`
`79`	`79`	`const parsed = assertSlackFileUrl(url);`
	`80`	`+ const { dispatcher: _dispatcher, redirect: _redirect, ...rest } = init ?? {};`
`80`	`81`	`const fetchImpl =`
`81`		`- "dispatcher" in (init ?? {}) && !isMockedFetch(globalThis.fetch)`
	`82`	`+ _dispatcher !== undefined && !isMockedFetch(globalThis.fetch)`
`82`	`83`	`? fetchWithRuntimeDispatcher`
`83`	`84`	`: globalThis.fetch;`
`84`		`- return fetchImpl(parsed.href, { ...init, redirect: "manual" });`
	`85`	`+ return fetchImpl(parsed.href, { ...rest, redirect: "manual" });`
`85`	`86`	`};`
`86`	`87`	`}`
`87`	`88`