Fix Discord native empty reply fallback

AliAbuelkheir · AliAbuelkheir · commit 6d05fd464ea6 · 2026-06-04T03:44:18.000+03:00
diff --git a/extensions/discord/src/monitor/native-command-agent-reply.ts b/extensions/discord/src/monitor/native-command-agent-reply.ts
@@ -28,6 +28,24 @@ type NativeCommandEffectiveRoute = {
   agentId: string;
 };
 
+function shouldSendNoVisibleReplyFallback(dispatchResult: {
+  counts: { final?: number; block?: number; tool?: number };
+  noVisibleReplyFallbackEligible?: boolean;
+  queuedFinal?: boolean;
+  sendPolicyDenied?: boolean;
+  sourceReplyDeliveryMode?: string;
+}): boolean {
+  return (
+    dispatchResult.noVisibleReplyFallbackEligible === true &&
+    dispatchResult.queuedFinal !== true &&
+    dispatchResult.sendPolicyDenied !== true &&
+    dispatchResult.sourceReplyDeliveryMode !== "message_tool_only" &&
+    (dispatchResult.counts.final ?? 0) === 0 &&
+    (dispatchResult.counts.block ?? 0) === 0 &&
+    (dispatchResult.counts.tool ?? 0) === 0
+  );
+}
+
 export async function dispatchDiscordNativeAgentReply(params: {
   cfg: OpenClawConfig;
   discordConfig: DiscordConfig;
@@ -106,7 +124,8 @@ export async function dispatchDiscordNativeAgentReply(params: {
     dispatchResult.queuedFinal ||
     dispatchResult.counts.final !== 0 ||
     dispatchResult.counts.block !== 0 ||
-    dispatchResult.counts.tool !== 0
+    dispatchResult.counts.tool !== 0 ||
+    !shouldSendNoVisibleReplyFallback(dispatchResult)
   ) {
     return;
   }
diff --git a/extensions/discord/src/monitor/native-command.plugin-dispatch.test.ts b/extensions/discord/src/monitor/native-command.plugin-dispatch.test.ts
@@ -901,6 +901,7 @@ describe("Discord native plugin command dispatch", () => {
     runtimeModuleMocks.dispatchReplyWithDispatcher.mockResolvedValue({
       counts: { final: 0, block: 0, tool: 0 },
       queuedFinal: false,
+      noVisibleReplyFallbackEligible: true,
     } as never);
     const command = await createNativeCommand(cfg, {
       name: "new",
@@ -917,6 +918,27 @@ describe("Discord native plugin command dispatch", () => {
     expect(interaction.reply).not.toHaveBeenCalled();
   });
 
+  it("does not warn when dispatch completes without a fallback-eligible visible reply", async () => {
+    const cfg = createConfig();
+    const interaction = createInteraction();
+    runtimeModuleMocks.matchPluginCommand.mockReturnValue(null);
+    runtimeModuleMocks.dispatchReplyWithDispatcher.mockResolvedValue({
+      counts: { final: 0, block: 0, tool: 0 },
+      queuedFinal: false,
+      noVisibleReplyFallbackEligible: false,
+    } as never);
+    const command = await createNativeCommand(cfg, {
+      name: "compact",
+      description: "Compact the active session.",
+      acceptsArgs: false,
+    });
+
+    await (command as { run: (interaction: unknown) => Promise<void> }).run(interaction as unknown);
+
+    expectNoFollowUpContent(interaction, "Command produced no visible reply.");
+    expect(interaction.reply).not.toHaveBeenCalled();
+  });
+
   it("does not warn when dispatch reports a queued final without visible counts", async () => {
     const cfg = createConfig();
     const interaction = createInteraction();
