fix(cli): format acp client errors with formatErrorMessage (#83904)

clawsweeper[bot] · hclsys · commit 69ef0e7270e2 · 2026-05-19T22:27:27.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ Docs: https://docs.openclaw.ai
 - Control UI: treat terminal session status as authoritative over stale active-run flags so completed terminal runs stop showing abort/live UI. (#84057)
 - CLI: preserve embedded equals signs in inline root option values instead of truncating after the second separator. (#83995) Thanks @ThiagoCAltoe.
 - Matrix/config: accept `messages.queue.byChannel.matrix` queue overrides and keep queue provider schema/type keys aligned for Matrix, Google Chat, and Mattermost. Thanks @bdjben.
+- CLI: format `openclaw acp client` failures through the shared error formatter so object-shaped errors stay readable instead of printing `[object Object]`. Fixes #83904. (#84080)
 - Providers/Ollama: default unknown-capabilities models to tool-capable so discovered native Ollama models can use tools when `/api/show` omits capabilities. (#84055) Thanks @dutifulbob.
 - Installer/Windows: launch `install.ps1` onboarding as an attached child process so fresh native Windows installs do not freeze visibly at `Starting setup...` or corrupt the wizard's terminal rendering.
 - Memory/search: close local embedding providers when active-memory searches time out so pending local model loads and embedding contexts are aborted and released. (#83858) Thanks @brokemac79.
diff --git a/src/cli/acp-cli.option-collisions.test.ts b/src/cli/acp-cli.option-collisions.test.ts
@@ -166,21 +166,15 @@ describe("acp cli option collisions", () => {
     expectCliError(/Failed to (inspect|read) Gateway token file/);
   });
 
-  // #83904: the `acp client` subcommand used `String(err)` while `acp` itself
-  // already routed through `formatErrorMessage`. Non-Error throws (e.g. plain
-  // objects) surfaced as `[object Object]` instead of a readable diagnostic.
-  // After this fix both subcommands share the same formatter.
   it("formats client errors with formatErrorMessage instead of String(err) (#83904)", async () => {
     runAcpClientInteractive.mockImplementationOnce(async () => {
-      // Plain-object throw: `String({})` → "[object Object]". `formatErrorMessage`
-      // produces something more useful for log triage.
       throw { code: 42, why: "boom" } as unknown as Error;
     });
     const program = createAcpProgram();
     await program.parseAsync(["acp", "client"], { from: "user" });
 
     const errors = defaultRuntime.error.mock.calls.map(([message]) => String(message));
-    expect(errors.some((message) => message.includes("[object Object]"))).toBe(false);
+    expect(errors).toContain('{"code":42,"why":"boom"}');
     expect(defaultRuntime.exit).toHaveBeenCalledWith(1);
   });
 });
diff --git a/src/cli/acp-cli.ts b/src/cli/acp-cli.ts
@@ -73,10 +73,6 @@ export function registerAcpCli(program: Command) {
           verbose: Boolean(opts.verbose || inheritedVerbose),
         });
       } catch (err) {
-        // Match the parent `acp` action a few lines up (line 52): both surfaces
-        // route errors through `formatErrorMessage`, which normalises plain
-        // Error objects and non-Error throws into a readable message instead of
-        // the default `[object Object]` from `String(err)`. See #83904.
         defaultRuntime.error(formatErrorMessage(err));
         defaultRuntime.exit(1);
       }
