test(channels): preserve thread origin contracts

steipete · web-flow · commit 645ef817b66e · 2026-05-18T02:30:24.000+01:00
Add core and hook mapper regression coverage for the thread-origin contract behind #83302.\n\nThe tests prove a flat reply target can coexist with a thread-addressable OriginatingTo, and hook canonical conversation mapping keeps following OriginatingTo.\n\nProof: focused Vitest, autoreview, Testbox check:changed tbx_01krwaztbwm13sx9e4sbyyz4c1, and CI run 26008670388 passed.
diff --git a/src/channels/inbound-event/context.test.ts b/src/channels/inbound-event/context.test.ts
@@ -228,6 +228,31 @@ describe("buildChannelInboundEventContext", () => {
     expect(ctx.InboundEventKind).toBe("room_event");
   });
 
+  it("preserves thread-addressable origins alongside flat reply targets", () => {
+    const ctx = buildChannelInboundEventContext(
+      createBaseContextParams({
+        conversation: {
+          kind: "group",
+          id: "room-1",
+          threadId: "topic-42",
+          routePeer: {
+            kind: "group",
+            id: "room-1",
+          },
+        },
+        reply: {
+          to: "test:room:room-1",
+          originatingTo: "test:room:room-1:topic:topic-42",
+          messageThreadId: "topic-42",
+        },
+      }),
+    );
+
+    expect(ctx.To).toBe("test:room:room-1");
+    expect(ctx.OriginatingTo).toBe("test:room:room-1:topic:topic-42");
+    expect(ctx.MessageThreadId).toBe("topic-42");
+  });
+
   it("keeps legacy command authorization fallback for authorizer arrays", () => {
     const ctx = buildChannelInboundEventContext(
       createBaseContextParams({
diff --git a/src/hooks/message-hook-mappers.test.ts b/src/hooks/message-hook-mappers.test.ts
@@ -131,6 +131,33 @@ describe("message hook mappers", () => {
     expect(canonical.messageId).toBe("override-msg");
   });
 
+  it("uses OriginatingTo as the canonical conversation when To is flat", () => {
+    const canonical = deriveInboundMessageHookContext(
+      makeInboundCtx({
+        To: "demo-chat:chat:456",
+        OriginatingTo: "demo-chat:chat:456:topic:42",
+        MessageThreadId: 42,
+      }),
+    );
+
+    expect(canonical.to).toBe("demo-chat:chat:456");
+    expect(canonical.conversationId).toBe("demo-chat:chat:456:topic:42");
+    expect(canonical.originatingTo).toBe("demo-chat:chat:456:topic:42");
+
+    const pluginContext = toPluginMessageContext(canonical);
+    expect(pluginContext.conversationId).toBe("demo-chat:chat:456:topic:42");
+
+    const receivedEvent = toPluginMessageReceivedEvent(canonical);
+    expect(receivedEvent.metadata?.to).toBe("demo-chat:chat:456");
+    expect(receivedEvent.metadata?.originatingTo).toBe("demo-chat:chat:456:topic:42");
+    expect(receivedEvent.metadata?.threadId).toBe(42);
+
+    const internalReceived = toInternalMessageReceivedContext(canonical);
+    expect(internalReceived.conversationId).toBe("demo-chat:chat:456:topic:42");
+    expect(internalReceived.metadata?.to).toBe("demo-chat:chat:456");
+    expect(internalReceived.metadata?.threadId).toBe(42);
+  });
+
   it("preserves multi-attachment arrays for inbound claim metadata", () => {
     const canonical = deriveInboundMessageHookContext(
       makeInboundCtx({
