refactor: share push test response assertions

vincentkoc · vincentkoc · commit 630f0d6938cd · 2026-06-01T07:36:51.000+02:00
diff --git a/src/gateway/server-methods/push.test.ts b/src/gateway/server-methods/push.test.ts
@@ -121,6 +121,16 @@ function firstRespondCall(respond: ReturnType<typeof vi.fn>): RespondCall | unde
   return respond.mock.calls[0] as RespondCall | undefined;
 }
 
+function expectSuccessfulPushTestResponse(respond: ReturnType<typeof vi.fn>): ApnsPushResult {
+  expect(sendApnsAlert).toHaveBeenCalledTimes(1);
+  const call = firstRespondCall(respond);
+  expect(call?.[0]).toBe(true);
+  const result = call?.[1] as ApnsPushResult | undefined;
+  expect(result?.ok).toBe(true);
+  expect(result?.status).toBe(200);
+  return result as ApnsPushResult;
+}
+
 describe("push.test handler", () => {
   beforeEach(() => {
     mocks.getRuntimeConfig.mockClear();
@@ -160,12 +170,7 @@ describe("push.test handler", () => {
     });
     await invoke();
 
-    expect(sendApnsAlert).toHaveBeenCalledTimes(1);
-    const call = firstRespondCall(respond);
-    expect(call?.[0]).toBe(true);
-    const result = call?.[1] as ApnsPushResult | undefined;
-    expect(result?.ok).toBe(true);
-    expect(result?.status).toBe(200);
+    expectSuccessfulPushTestResponse(respond);
   });
 
   it("sends push test through relay registrations", async () => {
@@ -223,12 +228,7 @@ describe("push.test handler", () => {
       },
       { registrationRelayOrigin: undefined },
     );
-    expect(sendApnsAlert).toHaveBeenCalledTimes(1);
-    const call = firstRespondCall(respond);
-    expect(call?.[0]).toBe(true);
-    const result = call?.[1] as ApnsPushResult | undefined;
-    expect(result?.ok).toBe(true);
-    expect(result?.status).toBe(200);
+    const result = expectSuccessfulPushTestResponse(respond);
     expect(result?.transport).toBe("relay");
   });
 
