test: tighten cron failure notification assertions

steipete · steipete · commit 624af621e663 · 2026-05-09T22:55:00.000+01:00
diff --git a/src/cron/delivery.failure-notify.test.ts b/src/cron/delivery.failure-notify.test.ts
@@ -79,21 +79,33 @@ describe("sendFailureNotificationAnnounce", () => {
       agentId: "main",
       sessionKey: "cron:job-1:failure",
     });
-    expect(mocks.deliverOutboundPayloads).toHaveBeenCalledWith(
-      expect.objectContaining({
-        cfg,
-        channel: "telegram",
-        to: "123",
-        accountId: "bot-a",
-        threadId: 42,
-        payloads: [{ text: "Cron failed" }],
-        session: { kind: "session" },
-        identity: { kind: "identity" },
-        bestEffort: false,
-        deps: { kind: "deps" },
-        abortSignal: expect.any(AbortSignal),
-      }),
-    );
+    expect(mocks.deliverOutboundPayloads).toHaveBeenCalledTimes(1);
+    const [deliveryRequest] = mocks.deliverOutboundPayloads.mock.calls[0] as [
+      {
+        abortSignal?: unknown;
+        accountId?: string;
+        bestEffort?: boolean;
+        cfg?: unknown;
+        channel?: string;
+        deps?: unknown;
+        identity?: unknown;
+        payloads?: unknown;
+        session?: unknown;
+        threadId?: number;
+        to?: string;
+      },
+    ];
+    expect(deliveryRequest.cfg).toBe(cfg);
+    expect(deliveryRequest.channel).toBe("telegram");
+    expect(deliveryRequest.to).toBe("123");
+    expect(deliveryRequest.accountId).toBe("bot-a");
+    expect(deliveryRequest.threadId).toBe(42);
+    expect(deliveryRequest.payloads).toEqual([{ text: "Cron failed" }]);
+    expect(deliveryRequest.session).toEqual({ kind: "session" });
+    expect(deliveryRequest.identity).toEqual({ kind: "identity" });
+    expect(deliveryRequest.bestEffort).toBe(false);
+    expect(deliveryRequest.deps).toEqual({ kind: "deps" });
+    expect(deliveryRequest.abortSignal).toBeInstanceOf(AbortSignal);
   });
 
   it("uses sessionKey for delivery-target resolution and outbound context", async () => {
@@ -158,13 +170,14 @@ describe("sendFailureNotificationAnnounce", () => {
       ),
     ).resolves.toBeUndefined();
 
-    expect(mocks.warn).toHaveBeenCalledWith(
-      expect.objectContaining({
-        err: "send failed",
-        channel: "telegram",
-        to: "123",
-      }),
-      "cron: failure destination announce failed",
-    );
+    expect(mocks.warn).toHaveBeenCalledTimes(1);
+    const [warnMeta, warnMessage] = mocks.warn.mock.calls[0] as [
+      { channel?: string; err?: string; to?: string },
+      string,
+    ];
+    expect(warnMeta.err).toBe("send failed");
+    expect(warnMeta.channel).toBe("telegram");
+    expect(warnMeta.to).toBe("123");
+    expect(warnMessage).toBe("cron: failure destination announce failed");
   });
 });
