Guard automatic Telegram reply delivery

baragozhelper-ux · baragozhelper-ux · commit 611909fb6a27 · 2026-05-09T17:13:34.000-07:00
diff --git a/extensions/telegram/src/bot/delivery.replies.ts b/extensions/telegram/src/bot/delivery.replies.ts
@@ -37,6 +37,10 @@ import {
   wrapFileReferencesInHtml,
 } from "../format.js";
 import { resolveTelegramInteractiveTextFallback } from "../interactive-fallback.js";
+import {
+  shouldSendTelegramRuntimeCommsMedia,
+  shouldSendTelegramRuntimeCommsText,
+} from "../runtime-comms-guard.js";
 import { buildInlineKeyboard } from "../send.js";
 import { resolveTelegramVoiceSend } from "../voice.js";
 import {
@@ -749,13 +753,12 @@ export async function deliverReplies(params: {
   }
   for (const originalReply of normalizedReplies) {
     let reply = originalReply;
-    const mediaList = reply?.mediaUrls?.length
+    let mediaList = reply?.mediaUrls?.length
       ? reply.mediaUrls
       : reply?.mediaUrl
         ? [reply.mediaUrl]
         : [];
-    const hasMedia = mediaList.length > 0;
-    const resolvedReplyText =
+    let resolvedReplyText =
       resolveTelegramInteractiveTextFallback({
         text: reply?.text,
         interactive: reply?.interactive,
@@ -765,6 +768,35 @@ export async function deliverReplies(params: {
     if (reply && resolvedReplyText !== (reply.text ?? "")) {
       reply = { ...reply, text: resolvedReplyText };
     }
+
+    const guardContext = {
+      to: params.chatId,
+      accountId: params.accountId,
+      threadId: params.thread?.id,
+    };
+    if (
+      resolvedReplyText &&
+      !(await shouldSendTelegramRuntimeCommsText({
+        context: guardContext,
+        text: resolvedReplyText,
+      }))
+    ) {
+      resolvedReplyText = "";
+      reply = { ...reply, text: "" };
+    }
+    if (mediaList.length > 0) {
+      const allowedMediaList: string[] = [];
+      for (const mediaUrl of mediaList) {
+        if (await shouldSendTelegramRuntimeCommsMedia({ context: guardContext, mediaUrl })) {
+          allowedMediaList.push(mediaUrl);
+        }
+      }
+      mediaList = allowedMediaList;
+      if (mediaList.length === 0 && reply) {
+        reply = { ...reply, mediaUrl: undefined, mediaUrls: undefined };
+      }
+    }
+    const hasMedia = mediaList.length > 0;
     if (!resolvedReplyText && !hasMedia) {
       if (reply?.audioAsVoice) {
         logVerbose("telegram reply has audioAsVoice without media/text; skipping");
diff --git a/extensions/telegram/src/bot/delivery.test.ts b/extensions/telegram/src/bot/delivery.test.ts
@@ -57,6 +57,7 @@ vi.mock("openclaw/plugin-sdk/plugin-runtime", async (importOriginal) => {
 
 vi.resetModules();
 const { deliverReplies } = await import("./delivery.js");
+const { clearTelegramRuntimeCommsGuardMemoryForTests } = await import("../runtime-comms-guard.js");
 
 vi.mock("grammy", () => ({
   API_CONSTANTS: {
@@ -175,6 +176,7 @@ function createVoiceFailureHarness(params: {
 
 describe("deliverReplies", () => {
   beforeEach(() => {
+    clearTelegramRuntimeCommsGuardMemoryForTests();
     loadWebMedia.mockClear();
     probeVideoDimensions.mockReset();
     probeVideoDimensions.mockResolvedValue(undefined);
@@ -185,6 +187,59 @@ describe("deliverReplies", () => {
     messageHookRunner.runMessageSent.mockReset();
   });
 
+  it("suppresses visible runtime guard text on automatic Telegram replies", async () => {
+    const runtime = createRuntime();
+    const sendMessage = vi.fn().mockResolvedValue({ message_id: 4101, chat: { id: "123" } });
+    const bot = createBot({ sendMessage });
+
+    await deliverWith({
+      bot,
+      runtime,
+      replies: [
+        {
+          text: "MODEL-GATE\ntask_type: small code/report edit\nproceed_status: PROCEED",
+        },
+      ],
+    });
+
+    expect(sendMessage).not.toHaveBeenCalled();
+  });
+
+  it("delivers requested markdown files immediately without leaking guard text", async () => {
+    const runtime = createRuntime();
+    const sendDocument = vi.fn().mockResolvedValue({ message_id: 4102, chat: { id: "123" } });
+    const sendMessage = vi.fn().mockResolvedValue({ message_id: 4103, chat: { id: "123" } });
+    const bot = createBot({ sendDocument, sendMessage });
+    mockMediaLoad("telegram-response-guide.md", "text/markdown", "# Telegram guide\n");
+
+    await deliverWith({
+      bot,
+      runtime,
+      replies: [
+        {
+          text: "MODEL-GATE\ntask_type: small code/report edit\nproceed_status: PROCEED",
+          mediaUrls: ["/tmp/telegram-response-guide.md"],
+        },
+        {
+          text: "Готово: файл доставлен.",
+        },
+      ],
+    });
+
+    expect(sendDocument).toHaveBeenCalledTimes(1);
+    expect(sendDocument).toHaveBeenCalledWith(
+      "123",
+      expect.anything(),
+      expect.not.objectContaining({ caption: expect.stringContaining("MODEL-GATE") }),
+    );
+    expect(sendMessage).toHaveBeenCalledTimes(1);
+    expect(sendMessage).toHaveBeenCalledWith(
+      "123",
+      expect.stringContaining("Готово: файл доставлен."),
+      expect.anything(),
+    );
+  });
+
   it("skips audioAsVoice-only payloads without logging an error", async () => {
     const runtime = createRuntime(false);
 
