fix: validate elevenlabs realtime numeric config

steipete · steipete · commit 607e6c206f4f · 2026-05-28T16:39:25.000-04:00
diff --git a/extensions/elevenlabs/realtime-transcription-provider.test.ts b/extensions/elevenlabs/realtime-transcription-provider.test.ts
@@ -39,6 +39,58 @@ describe("buildElevenLabsRealtimeTranscriptionProvider", () => {
     });
   });
 
+  it("drops malformed numeric realtime config values", () => {
+    const provider = buildElevenLabsRealtimeTranscriptionProvider();
+    const resolved = provider.resolveConfig?.({
+      cfg: {} as OpenClawConfig,
+      rawConfig: {
+        providers: {
+          elevenlabs: {
+            sample_rate: "8000.5",
+            vad_silence_threshold_secs: "999",
+            vad_threshold: "0",
+            min_speech_duration_ms: "0",
+            min_silence_duration_ms: "10.5",
+          },
+        },
+      },
+    });
+
+    expect(resolved).toMatchObject({
+      sampleRate: undefined,
+      vadSilenceThresholdSecs: undefined,
+      vadThreshold: undefined,
+      minSpeechDurationMs: undefined,
+      minSilenceDurationMs: undefined,
+    });
+  });
+
+  it("keeps realtime VAD numeric config inside provider ranges", () => {
+    const provider = buildElevenLabsRealtimeTranscriptionProvider();
+    const resolved = provider.resolveConfig?.({
+      cfg: {} as OpenClawConfig,
+      rawConfig: {
+        providers: {
+          elevenlabs: {
+            sample_rate: "8000",
+            vad_silence_threshold_secs: "3",
+            vad_threshold: "0.9",
+            min_speech_duration_ms: "50",
+            min_silence_duration_ms: "2000",
+          },
+        },
+      },
+    });
+
+    expect(resolved).toMatchObject({
+      sampleRate: 8000,
+      vadSilenceThresholdSecs: 3,
+      vadThreshold: 0.9,
+      minSpeechDurationMs: 50,
+      minSilenceDurationMs: 2000,
+    });
+  });
+
   it("builds an ElevenLabs realtime websocket URL", () => {
     const url = testing.toElevenLabsRealtimeWsUrl({
       apiKey: "eleven-key",
diff --git a/extensions/elevenlabs/realtime-transcription-provider.ts b/extensions/elevenlabs/realtime-transcription-provider.ts
@@ -78,6 +78,23 @@ function normalizeCommitStrategy(value: unknown): "manual" | "vad" | undefined {
   throw new Error(`Invalid ElevenLabs realtime transcription commit strategy: ${normalized}`);
 }
 
+function normalizePositiveSafeInteger(value: unknown): number | undefined {
+  const parsed = readFiniteNumber(value);
+  return parsed !== undefined && Number.isSafeInteger(parsed) && parsed > 0 ? parsed : undefined;
+}
+
+function normalizeFiniteRange(value: unknown, min: number, max: number): number | undefined {
+  const parsed = readFiniteNumber(value);
+  return parsed !== undefined && parsed >= min && parsed <= max ? parsed : undefined;
+}
+
+function normalizeIntegerRange(value: unknown, min: number, max: number): number | undefined {
+  const parsed = readFiniteNumber(value);
+  return parsed !== undefined && Number.isSafeInteger(parsed) && parsed >= min && parsed <= max
+    ? parsed
+    : undefined;
+}
+
 function normalizeProviderConfig(
   config: RealtimeTranscriptionProviderConfig,
 ): ElevenLabsRealtimeTranscriptionProviderConfig {
@@ -90,15 +107,25 @@ function normalizeProviderConfig(
     baseUrl: normalizeOptionalString(raw.baseUrl),
     modelId: normalizeOptionalString(raw.modelId ?? raw.model ?? raw.sttModel),
     audioFormat: normalizeOptionalString(raw.audioFormat ?? raw.audio_format ?? raw.encoding),
-    sampleRate: readFiniteNumber(raw.sampleRate ?? raw.sample_rate),
+    sampleRate: normalizePositiveSafeInteger(raw.sampleRate ?? raw.sample_rate),
     languageCode: normalizeOptionalString(raw.languageCode ?? raw.language),
     commitStrategy: normalizeCommitStrategy(raw.commitStrategy ?? raw.commit_strategy),
-    vadSilenceThresholdSecs: readFiniteNumber(
+    vadSilenceThresholdSecs: normalizeFiniteRange(
       raw.vadSilenceThresholdSecs ?? raw.vad_silence_threshold_secs,
+      0.3,
+      3,
+    ),
+    vadThreshold: normalizeFiniteRange(raw.vadThreshold ?? raw.vad_threshold, 0.1, 0.9),
+    minSpeechDurationMs: normalizeIntegerRange(
+      raw.minSpeechDurationMs ?? raw.min_speech_duration_ms,
+      50,
+      2_000,
+    ),
+    minSilenceDurationMs: normalizeIntegerRange(
+      raw.minSilenceDurationMs ?? raw.min_silence_duration_ms,
+      50,
+      2_000,
     ),
-    vadThreshold: readFiniteNumber(raw.vadThreshold ?? raw.vad_threshold),
-    minSpeechDurationMs: readFiniteNumber(raw.minSpeechDurationMs ?? raw.min_speech_duration_ms),
-    minSilenceDurationMs: readFiniteNumber(raw.minSilenceDurationMs ?? raw.min_silence_duration_ms),
   };
 }
 
