fix(agents): cancel local service probe bodies

vincentkoc · vincentkoc · commit 5d6ac2308657 · 2026-06-19T08:24:54.000+02:00
diff --git a/src/agents/provider-local-service.test.ts b/src/agents/provider-local-service.test.ts
@@ -187,6 +187,60 @@ describe("provider local service", () => {
     await waitForProbeFailure(healthUrl);
   });
 
+  it("cancels local service health probe response bodies", async () => {
+    let socketClosed = false;
+    const sockets = new Set<net.Socket>();
+    const server = net.createServer((socket) => {
+      sockets.add(socket);
+      socket.on("error", () => undefined);
+      socket.on("close", () => {
+        sockets.delete(socket);
+        socketClosed = true;
+      });
+      socket.write(
+        ["HTTP/1.1 200 OK", "Content-Type: application/json", "", '{"ok":true}'].join("\r\n"),
+      );
+    });
+    await new Promise<void>((resolve, reject) => {
+      server.once("error", reject);
+      server.listen(0, "127.0.0.1", () => {
+        server.off("error", reject);
+        resolve();
+      });
+    });
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("missing test server port");
+    }
+    const model = attachModelProviderLocalService(
+      {
+        id: "demo",
+        provider: "local-body-cleanup",
+        api: "openai-completions",
+        baseUrl: `http://127.0.0.1:${address.port}/v1`,
+      } as unknown as Model<"openai-completions">,
+      {
+        command: process.execPath,
+        args: ["--version"],
+        healthUrl: `http://127.0.0.1:${address.port}/v1/models`,
+        readyTimeoutMs: 1_000,
+        idleStopMs: 1,
+      },
+    );
+
+    try {
+      await expect(ensureModelProviderLocalService(model)).resolves.toBeUndefined();
+      await expect.poll(() => socketClosed, { timeout: 1000, interval: 20 }).toBe(true);
+    } finally {
+      for (const socket of sockets) {
+        socket.destroy();
+      }
+      await new Promise<void>((resolve, reject) => {
+        server.close((error) => (error ? reject(error) : resolve()));
+      });
+    }
+  });
+
   it("serializes concurrent cold starts for the same local service", async () => {
     const port = await freePort();
     const healthUrl = `http://127.0.0.1:${port}/v1/models`;
diff --git a/src/agents/provider-local-service.ts b/src/agents/provider-local-service.ts
@@ -226,8 +226,9 @@ async function probeHealth(
   timeout.unref?.();
   const onAbort = () => controller.abort(toAbortError(signal));
   signal?.addEventListener("abort", onAbort, { once: true });
+  let response: Response | undefined;
   try {
-    const response = await fetch(url, { headers, signal: controller.signal });
+    response = await fetch(url, { headers, signal: controller.signal });
     return response.ok;
   } catch {
     if (signal?.aborted) {
@@ -237,6 +238,7 @@ async function probeHealth(
   } finally {
     clearTimeout(timeout);
     signal?.removeEventListener("abort", onAbort);
+    await response?.body?.cancel?.().catch(() => undefined);
   }
 }
 
