fix(memory): scope provider-none FTS bypass

vincentkoc · vincentkoc · commit 5a4f868de0db · 2026-06-02T14:53:34.000+02:00
diff --git a/extensions/memory-core/src/memory/manager-sync-ops.ts b/extensions/memory-core/src/memory/manager-sync-ops.ts
@@ -290,7 +290,7 @@ export abstract class MemoryManagerSyncOps {
   }): MemoryIndexIdentityState {
     const hasProviderOverride = params && "provider" in params;
     const configuredProvider =
-      !this.vector.enabled || this.settings.provider === "none"
+      this.settings.provider === "none"
         ? null
         : {
             id:
diff --git a/extensions/memory-core/src/memory/manager.fts-only-reindex.test.ts b/extensions/memory-core/src/memory/manager.fts-only-reindex.test.ts
@@ -129,7 +129,7 @@ describe("memory manager FTS-only reindex", () => {
     expect(countChunksContaining("Alpha topic")).toBeGreaterThan(0);
   });
 
-  it("syncs vector-disabled memory without resolving an embedding provider", async () => {
+  it("syncs explicit provider-none memory without resolving an embedding provider", async () => {
     const memoryManager = await createManager({ provider: "none", vectorEnabled: false });
 
     await memoryManager.sync({ force: true });
@@ -139,6 +139,15 @@ describe("memory manager FTS-only reindex", () => {
     expect(memoryManager.status().custom?.indexIdentity).toEqual({ status: "valid" });
   });
 
+  it("still initializes configured providers when vector storage is disabled", async () => {
+    const memoryManager = await createManager({ provider: "auto", vectorEnabled: false });
+
+    await memoryManager.sync({ force: true });
+
+    expect(createEmbeddingProviderMock).toHaveBeenCalledOnce();
+    expect(countChunksContaining("Alpha topic")).toBeGreaterThan(0);
+  });
+
   it("refreshes FTS-only indexed content after memory file updates", async () => {
     const memoryManager = await createManager();
     await memoryManager.sync({ force: true });
diff --git a/extensions/memory-core/src/memory/manager.ts b/extensions/memory-core/src/memory/manager.ts
@@ -392,13 +392,14 @@ export class MemoryIndexManager extends MemoryManagerEmbeddingOps implements Mem
   }
 
   private refreshIndexIdentityDirty(params?: { providerKeyKnown?: boolean }) {
-    const provider = !this.vector.enabled
-      ? null
-      : this.providerInitialized
-        ? this.provider
-          ? { id: this.provider.id, model: this.provider.model }
-          : null
-        : undefined;
+    const provider =
+      this.settings.provider === "none"
+        ? null
+        : this.providerInitialized
+          ? this.provider
+            ? { id: this.provider.id, model: this.provider.model }
+            : null
+          : undefined;
     const state = this.resolveCurrentIndexIdentityState({
       ...(provider !== undefined ? { provider } : {}),
       providerKeyKnown: params?.providerKeyKnown,
@@ -453,7 +454,7 @@ export class MemoryIndexManager extends MemoryManagerEmbeddingOps implements Mem
         log.warn(`memory sync failed (search): ${String(err)}`);
       },
     });
-    if (preflight.shouldInitializeProvider && this.vector.enabled) {
+    if (preflight.shouldInitializeProvider && this.settings.provider !== "none") {
       await this.ensureProviderInitialized();
     }
     if (!this.provider && this.providerLifecycle.mode === "degraded") {
@@ -791,7 +792,7 @@ export class MemoryIndexManager extends MemoryManagerEmbeddingOps implements Mem
       return this.syncing;
     }
     this.syncing = (async () => {
-      if (this.vector.enabled) {
+      if (this.settings.provider !== "none") {
         await this.ensureProviderInitialized();
       }
       await this.runSyncWithReadonlyRecovery(params);
