fix(crabbox): preserve sparse run artifacts

vincentkoc · vincentkoc · commit 53ad531df918 · 2026-05-28T00:20:39.000+02:00
diff --git a/scripts/crabbox-wrapper.mjs b/scripts/crabbox-wrapper.mjs
@@ -4,8 +4,11 @@ import {
   accessSync,
   chmodSync,
   constants,
+  cpSync,
+  mkdirSync,
   mkdtempSync,
   readFileSync,
+  readdirSync,
   rmSync,
   statSync,
   writeFileSync,
@@ -585,6 +588,42 @@ function absolutizeLocalRunPaths(commandArgs) {
   return normalizedArgs;
 }
 
+function pathExists(path) {
+  try {
+    statSync(path);
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+function preserveTemporaryCrabboxRuns() {
+  if (childCwd === repoRoot) {
+    return;
+  }
+
+  const sourceRuns = resolve(childCwd, ".crabbox", "runs");
+  if (!pathExists(sourceRuns)) {
+    return;
+  }
+
+  const targetRuns = resolve(repoRoot, ".crabbox", "runs");
+  mkdirSync(targetRuns, { recursive: true });
+  let preserved = 0;
+  for (const entry of readdirSync(sourceRuns)) {
+    cpSync(resolve(sourceRuns, entry), resolve(targetRuns, entry), {
+      recursive: true,
+      force: true,
+    });
+    preserved += 1;
+  }
+  if (preserved > 0) {
+    console.error(
+      `[crabbox] preserved ${preserved} temporary run artifact ${preserved === 1 ? "directory" : "directories"} under ${relative(repoRoot, targetRuns)}`,
+    );
+  }
+}
+
 function shellQuote(value) {
   const text = `${value}`;
   if (text === "") {
@@ -1861,6 +1900,7 @@ function cleanupOnce() {
   }
   cleanupDone = true;
   scriptBootstrap.cleanup();
+  preserveTemporaryCrabboxRuns();
   cleanupChildCwd();
 }
 
diff --git a/test/scripts/crabbox-wrapper.test.ts b/test/scripts/crabbox-wrapper.test.ts
@@ -1,5 +1,5 @@
 import { spawnSync } from "node:child_process";
-import { chmodSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { chmodSync, mkdirSync, mkdtempSync, rmSync, statSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import path from "node:path";
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
@@ -53,6 +53,12 @@ function writeFakeCrabbox(binDir: string, helpText: string): string {
       "    fi",
       "  done",
       "fi",
+      'for arg in "$@"; do',
+      '  if [ "$arg" = "--artifact-glob" ] || [ "$arg" = "-artifact-glob" ]; then',
+      "    mkdir -p .crabbox/runs/run_fake",
+      '    printf "%s\\n" "fake artifact" > .crabbox/runs/run_fake/fake-artifacts.tgz',
+      "  fi",
+      "done",
       'script_path=""',
       'previous_arg=""',
       'for arg in "$@"; do',
@@ -91,6 +97,10 @@ function writeFakeCrabbox(binDir: string, helpText: string): string {
     "const scriptIndex = args.findIndex((arg) => arg === '--script' || arg === '-script');",
     "const scriptPath = scriptIndex >= 0 ? args[scriptIndex + 1] : '';",
     "const scriptContent = scriptPath ? require('node:fs').readFileSync(scriptPath, 'utf8') : '';",
+    "if (args.includes('--artifact-glob') || args.includes('-artifact-glob')) {",
+    "  require('node:fs').mkdirSync('.crabbox/runs/run_fake', { recursive: true });",
+    "  require('node:fs').writeFileSync('.crabbox/runs/run_fake/fake-artifacts.tgz', 'fake artifact\\n');",
+    "}",
     "console.log(JSON.stringify({ args, cwd: process.cwd(), scriptContent }));",
   ].join("\n");
   writeFileSync(helperPath, `${helperScript}\n`, "utf8");
@@ -2234,6 +2244,40 @@ describe.concurrent("scripts/crabbox-wrapper", () => {
     expect(output.args).toContain(`/tmp/proof=${path.join(repoRoot, ".artifacts/proof")}`);
   });
 
+  it("preserves artifact-glob downloads from temporary sparse-sync checkouts", () => {
+    const preservedDir = path.join(repoRoot, ".crabbox", "runs", "run_fake");
+    rmSync(preservedDir, { recursive: true, force: true });
+
+    const result = runWrapper(
+      "provider: hetzner, aws, local-container, blacksmith-testbox, or cloudflare\n",
+      [
+        "run",
+        "--provider",
+        "blacksmith-testbox",
+        "--blacksmith-ref",
+        "main",
+        "--artifact-glob",
+        ".artifacts/proof/**",
+        "--",
+        "echo ok",
+      ],
+      {
+        gitResponses: {
+          ["config\u0000--bool\u0000core.sparseCheckout"]: { stdout: "true\n" },
+          ["status\u0000--porcelain=v1"]: { stdout: "" },
+        },
+      },
+    );
+
+    const output = parseFakeCrabboxOutput(result);
+    expect(result.status).toBe(0);
+    expect(output.cwd).toContain("openclaw-crabbox-sync-");
+    expect(result.stderr).toContain("syncing from temporary full checkout");
+    expect(result.stderr).toContain("preserved");
+    expect(statSync(path.join(preservedDir, "fake-artifacts.tgz")).isFile()).toBe(true);
+    rmSync(preservedDir, { recursive: true, force: true });
+  });
+
   it("uses the temporary full checkout for sparse sync-only runs", () => {
     const result = runWrapper(
       "provider: hetzner, aws, local-container, blacksmith-testbox, or cloudflare\n",
