fix(test): scope proxy-routed-no-reasoning test to a non-compat baseUrl (#70904)

hclsys · hclsys · commit 4dbf49a57957 · 2026-04-25T02:16:48.000+08:00
The existing test asserted "does not add reasoning for non-reasoning models without existing reasoning payload" but the fixture used { api: "openai-responses", provider: "openai", id: "gpt-5.2" } with no baseUrl — resolveOpenAIRequestCapabilities treats that as the default endpoint class, which has supportsOpenAIReasoningCompatPayload === true. The test was passing only because the pre-fix wrapper silently skipped undefined payload.reasoning. After the #70904 fix, the new !existingReasoning branch correctly injects { effort: "medium" } for that compat-capable route, so the assertion breaks. Rename the test to reflect what it should actually cover (proxy routes that fail the compat gate) and add baseUrl: "https://proxy.example.com/v1" to force shouldApplyOpenAIReasoningCompatibility === false. With that, the wrapper returns early and payload.reasoning stays undefined, as intended. Diagnosis + suggested fix from the #70904 reporter (@douglferreira977) and Greptile.
diff --git a/src/agents/pi-embedded-runner/openai-stream-wrappers.test.ts b/src/agents/pi-embedded-runner/openai-stream-wrappers.test.ts
@@ -79,10 +79,23 @@ describe("createOpenAIThinkingLevelWrapper", () => {
     expect(payloads[0]?.reasoning).toEqual({ effort: "low" });
   });
 
-  it("does not add reasoning for non-reasoning models without existing reasoning payload", () => {
+  it("does not add reasoning for proxy-routed models without existing reasoning payload", () => {
+    // Proxy routes fail shouldApplyOpenAIReasoningCompatibility, so the wrapper
+    // must not inject `body.reasoning` even with the #70904 !existingReasoning
+    // branch. Use a baseUrl that routes the request away from default OpenAI
+    // endpoints to exercise the non-compat path.
     const { baseStreamFn, payloads } = createPayloadCapture();
     const wrapped = createOpenAIThinkingLevelWrapper(baseStreamFn, "medium");
-    void wrapped(openaiModel, { messages: [] }, {});
+    void wrapped(
+      {
+        api: "openai-responses",
+        provider: "openai",
+        id: "gpt-5.2",
+        baseUrl: "https://proxy.example.com/v1",
+      } as Model<"openai-responses">,
+      { messages: [] },
+      {},
+    );
 
     expect(payloads[0]?.reasoning).toBeUndefined();
   });
