fix(minimax): validate directive numbers

steipete · steipete · commit 4925f84219ff · 2026-05-29T09:58:21.000-04:00
diff --git a/extensions/minimax/speech-provider.test.ts b/extensions/minimax/speech-provider.test.ts
@@ -245,6 +245,13 @@ describe("buildMinimaxSpeechProvider", () => {
       expect(result.overrides).toBeUndefined();
     });
 
+    it("warns on non-decimal speed values", () => {
+      const result = parseDirectiveToken({ key: "speed", value: "0x1", policy });
+      expect(result.handled).toBe(true);
+      expect(result.warnings).toHaveLength(1);
+      expect(result.overrides).toBeUndefined();
+    });
+
     it("handles vol key", () => {
       const result = parseDirectiveToken({ key: "vol", value: "3", policy });
       expect(result.handled).toBe(true);
@@ -257,6 +264,13 @@ describe("buildMinimaxSpeechProvider", () => {
       expect(result.warnings).toHaveLength(1);
     });
 
+    it("warns on non-decimal volume values", () => {
+      const result = parseDirectiveToken({ key: "vol", value: "0x3", policy });
+      expect(result.handled).toBe(true);
+      expect(result.warnings).toHaveLength(1);
+      expect(result.overrides).toBeUndefined();
+    });
+
     it("handles volume alias", () => {
       const result = parseDirectiveToken({ key: "volume", value: "5", policy });
       expect(result.handled).toBe(true);
@@ -275,6 +289,13 @@ describe("buildMinimaxSpeechProvider", () => {
       expect(result.warnings).toHaveLength(1);
     });
 
+    it("warns on non-decimal pitch values", () => {
+      const result = parseDirectiveToken({ key: "pitch", value: "0x3", policy });
+      expect(result.handled).toBe(true);
+      expect(result.warnings).toHaveLength(1);
+      expect(result.overrides).toBeUndefined();
+    });
+
     it("returns handled=false for unknown keys", () => {
       const result = parseDirectiveToken({
         key: "unknown_key",
diff --git a/extensions/minimax/speech-provider.ts b/extensions/minimax/speech-provider.ts
@@ -12,7 +12,10 @@ import type {
   SpeechProviderPlugin,
 } from "openclaw/plugin-sdk/speech-core";
 import { asObject, trimToUndefined } from "openclaw/plugin-sdk/speech-core";
-import { asFiniteNumberInRange } from "openclaw/plugin-sdk/string-coerce-runtime";
+import {
+  asFiniteNumberInRange,
+  parseStrictFiniteNumber,
+} from "openclaw/plugin-sdk/string-coerce-runtime";
 import {
   DEFAULT_MINIMAX_TTS_BASE_URL,
   MINIMAX_TTS_MODELS,
@@ -128,6 +131,10 @@ function normalizeMinimaxPitch(value: unknown): number | undefined {
   return pitch !== undefined ? Math.trunc(pitch) : undefined;
 }
 
+function parseDirectiveFiniteNumber(value: string): number | undefined {
+  return parseStrictFiniteNumber(value);
+}
+
 function readMinimaxProviderConfig(
   config: SpeechProviderConfig,
   cfg?: OpenClawConfig,
@@ -185,8 +192,8 @@ function parseDirectiveToken(ctx: SpeechDirectiveTokenParseContext): {
       if (!ctx.policy.allowVoiceSettings) {
         return { handled: true };
       }
-      const speed = Number(ctx.value);
-      if (!Number.isFinite(speed) || speed < 0.5 || speed > 2.0) {
+      const speed = parseDirectiveFiniteNumber(ctx.value);
+      if (speed === undefined || speed < 0.5 || speed > 2.0) {
         return { handled: true, warnings: [`invalid MiniMax speed "${ctx.value}" (0.5-2.0)`] };
       }
       return { handled: true, overrides: { speed } };
@@ -196,8 +203,8 @@ function parseDirectiveToken(ctx: SpeechDirectiveTokenParseContext): {
       if (!ctx.policy.allowVoiceSettings) {
         return { handled: true };
       }
-      const vol = Number(ctx.value);
-      if (!Number.isFinite(vol) || vol <= 0 || vol > 10) {
+      const vol = parseDirectiveFiniteNumber(ctx.value);
+      if (vol === undefined || vol <= 0 || vol > 10) {
         return {
           handled: true,
           warnings: [`invalid MiniMax volume "${ctx.value}" (0-10, exclusive)`],
@@ -209,8 +216,8 @@ function parseDirectiveToken(ctx: SpeechDirectiveTokenParseContext): {
       if (!ctx.policy.allowVoiceSettings) {
         return { handled: true };
       }
-      const pitch = Number(ctx.value);
-      if (!Number.isFinite(pitch) || pitch < -12 || pitch > 12) {
+      const pitch = parseDirectiveFiniteNumber(ctx.value);
+      if (pitch === undefined || pitch < -12 || pitch > 12) {
         return { handled: true, warnings: [`invalid MiniMax pitch "${ctx.value}" (-12 to 12)`] };
       }
       return { handled: true, overrides: { pitch } };
