fix: validate runway video durations

steipete · steipete · commit 48291462ef98 · 2026-05-28T16:35:09.000-04:00
diff --git a/extensions/runway/video-generation-provider.test.ts b/extensions/runway/video-generation-provider.test.ts
@@ -115,6 +115,41 @@ describe("runway video generation provider", () => {
     expect(metadata.endpoint).toBe("/v1/text_to_video");
   });
 
+  it("does not round malformed duration values into create requests", async () => {
+    postJsonRequestMock.mockResolvedValue({
+      response: {
+        json: async () => ({ id: "task-duration" }),
+      },
+      release: vi.fn(async () => {}),
+    });
+    fetchWithTimeoutMock
+      .mockResolvedValueOnce({
+        json: async () => ({
+          id: "task-duration",
+          status: "SUCCEEDED",
+          output: ["https://example.com/out.mp4"],
+        }),
+        headers: new Headers(),
+      })
+      .mockResolvedValueOnce({
+        arrayBuffer: async () => Buffer.from("mp4-bytes"),
+        headers: new Headers({ "content-type": "video/mp4" }),
+      });
+
+    const provider = buildRunwayVideoGenerationProvider();
+    await provider.generateVideo({
+      provider: "runway",
+      model: "gen4.5",
+      prompt: "a tiny lobster DJ under neon lights",
+      cfg: {},
+      durationSeconds: 4.5,
+      aspectRatio: "16:9",
+    });
+
+    expect(postJsonRequestMock).toHaveBeenCalledTimes(1);
+    expect(firstPostJsonRequest().body?.duration).toBe(5);
+  });
+
   it("accepts local image buffers by converting them into data URIs", async () => {
     postJsonRequestMock.mockResolvedValue({
       response: {
diff --git a/extensions/runway/video-generation-provider.ts b/extensions/runway/video-generation-provider.ts
@@ -149,7 +149,10 @@ function resolveDurationSeconds(value: number | undefined): number {
   if (typeof value !== "number" || !Number.isFinite(value)) {
     return 5;
   }
-  return Math.max(2, Math.min(MAX_DURATION_SECONDS, Math.round(value)));
+  if (!Number.isSafeInteger(value)) {
+    return 5;
+  }
+  return Math.max(2, Math.min(MAX_DURATION_SECONDS, value));
 }
 
 function resolveRunwayRatio(req: VideoGenerationRequest): string {

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,10 @@ function resolveDurationSeconds(value: number \| undefined): number {`
`149`	`149`	`if (typeof value !== "number" \|\| !Number.isFinite(value)) {`
`150`	`150`	`return 5;`
`151`	`151`	`}`
`152`		`- return Math.max(2, Math.min(MAX_DURATION_SECONDS, Math.round(value)));`
	`152`	`+ if (!Number.isSafeInteger(value)) {`
	`153`	`+ return 5;`
	`154`	`+ }`
	`155`	`+ return Math.max(2, Math.min(MAX_DURATION_SECONDS, value));`
`153`	`156`	`}`
`154`	`157`
`155`	`158`	`function resolveRunwayRatio(req: VideoGenerationRequest): string {`