fix(ci): restore persisted state guards

vincentkoc · vincentkoc · commit 46a67d30afa3 · 2026-05-16T18:06:13.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -38,6 +38,7 @@ Docs: https://docs.openclaw.ai
 - Commitments: strip malformed optional reminder scope metadata from persisted commitments before matching pending follow-ups.
 - Config persistence: normalize malformed auth profile credential fields/state, skip JSON-valid garbage transcript checkpoint rows, and let `openclaw doctor --fix` remove unrepairable cron job rows.
 - Cron: skip persisted job rows with malformed schedule or payload shapes in memory, leaving the store for `openclaw doctor --fix` instead of hydrating them into runtime state.
+- Cron: keep legacy string schedules and blank system-event jobs available for runtime repair/skip handling instead of dropping them as malformed persisted rows.
 - Task persistence: drop malformed array/scalar requester-origin JSON from task and task-flow SQLite sidecars instead of restoring it as delivery metadata.
 - Agents/timeouts: clarify model idle-timeout errors and docs so provider `timeoutSeconds` is shown as bounded by the whole agent/run timeout ceiling.
 - Release tooling: align the published launcher Node floor, `npm start`, package script checks, sharded lint locking, Vitest root project coverage, and plugin-SDK declaration build cache metadata so release/package validation does not silently skip or ship stale surfaces.
diff --git a/extensions/discord/src/monitor/model-picker.view.ts b/extensions/discord/src/monitor/model-picker.view.ts
@@ -370,12 +370,17 @@ function buildModelRows(params: {
             modelIndex: params.pendingModelIndex,
             userId: params.userId,
           }),
-          options: runtimeChoices.map((choice) => ({
-            label: choice.label,
-            value: choice.id,
-            default: choice.id === selectedRuntime,
-            ...(choice.description ? { description: choice.description } : {}),
-          })),
+          options: runtimeChoices.map((choice) => {
+            const option: APISelectMenuOption = {
+              label: choice.label,
+              value: choice.id,
+              default: choice.id === selectedRuntime,
+            };
+            if (choice.description) {
+              option.description = choice.description;
+            }
+            return option;
+          }),
           placeholder: "Select runtime",
         }),
       ]),
diff --git a/src/cron/persisted-shape.ts b/src/cron/persisted-shape.ts
@@ -15,7 +15,13 @@ export function getInvalidPersistedCronJobReason(
     return "missing-id";
   }
   const schedule = candidate.schedule;
-  if (!schedule || typeof schedule !== "object" || Array.isArray(schedule)) {
+  if (!schedule || Array.isArray(schedule)) {
+    return "missing-schedule";
+  }
+  if (typeof schedule === "string") {
+    return null;
+  }
+  if (typeof schedule !== "object") {
     return "missing-schedule";
   }
   const scheduleRecord = schedule as Record<string, unknown>;
@@ -52,7 +58,7 @@ export function getInvalidPersistedCronJobReason(
   }
   if (payloadKind === "systemEvent") {
     const text = payloadRecord.text;
-    if (typeof text !== "string" || text.trim().length === 0) {
+    if (typeof text !== "string") {
       return "invalid-payload";
     }
   }
diff --git a/src/pairing/pairing-store.test.ts b/src/pairing/pairing-store.test.ts
@@ -301,7 +301,7 @@ async function expectPendingPairingRequestsIsolatedByAccount(params: {
 describe("pairing store", () => {
   it("skips malformed persisted pairing requests while approving valid codes", async () => {
     await withTempStateDir(async (stateDir) => {
-      const now = new Date("2026-05-16T05:20:00.000Z").toISOString();
+      const now = new Date().toISOString();
       writeJsonFixture(resolvePairingFilePath(stateDir, "telegram"), {
         version: 1,
         requests: [

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,13 @@ export function getInvalidPersistedCronJobReason(`
`15`	`15`	`return "missing-id";`
`16`	`16`	`}`
`17`	`17`	`const schedule = candidate.schedule;`
`18`		`- if (!schedule \|\| typeof schedule !== "object" \|\| Array.isArray(schedule)) {`
	`18`	`+ if (!schedule \|\| Array.isArray(schedule)) {`
	`19`	`+ return "missing-schedule";`
	`20`	`+ }`
	`21`	`+ if (typeof schedule === "string") {`
	`22`	`+ return null;`
	`23`	`+ }`
	`24`	`+ if (typeof schedule !== "object") {`
`19`	`25`	`return "missing-schedule";`
`20`	`26`	`}`
`21`	`27`	`const scheduleRecord = schedule as Record<string, unknown>;`
`@@ -52,7 +58,7 @@ export function getInvalidPersistedCronJobReason(`
`52`	`58`	`}`
`53`	`59`	`if (payloadKind === "systemEvent") {`
`54`	`60`	`const text = payloadRecord.text;`
`55`		`- if (typeof text !== "string" \|\| text.trim().length === 0) {`
	`61`	`+ if (typeof text !== "string") {`
`56`	`62`	`return "invalid-payload";`
`57`	`63`	`}`
`58`	`64`	`}`