test(agents): narrow bounded error assertions

vincentkoc · vincentkoc · commit 44027e72d07e · 2026-05-28T07:17:21.000+02:00
diff --git a/src/agents/minimax-vlm.normalizes-api-key.test.ts b/src/agents/minimax-vlm.normalizes-api-key.test.ts
@@ -178,9 +178,11 @@ describe("minimaxUnderstandImage apiKey normalization", () => {
       prompt: "hi",
       imageDataUrl: "data:image/png;base64,AAAA",
       apiHost: "https://api.minimax.io",
-    }).catch((caught: unknown) => caught as Error);
+    }).catch((caught: unknown) => caught);
 
-    expect(error).toBeInstanceOf(Error);
+    if (!(error instanceof Error)) {
+      throw new Error("expected MiniMax VLM request to throw an Error");
+    }
     expect(error.message).toContain("MiniMax VLM request failed");
     expect(error.message).toContain("Trace-Id: trace-123");
     expect(error.message).not.toContain("tail-marker");
diff --git a/src/agents/tools/pdf-native-providers.test.ts b/src/agents/tools/pdf-native-providers.test.ts
@@ -131,9 +131,11 @@ describe("native PDF provider API calls", () => {
 
     const error = await pdfNativeProviders
       .anthropicAnalyzePdf(makeAnthropicAnalyzeParams())
-      .catch((caught: unknown) => caught as Error);
+      .catch((caught: unknown) => caught);
 
-    expect(error).toBeInstanceOf(Error);
+    if (!(error instanceof Error)) {
+      throw new Error("expected Anthropic PDF request to throw an Error");
+    }
     expect(error.message).toContain("Anthropic PDF request failed");
     expect(error.message).not.toContain("tail-marker");
     expect(error.message.length).toBeLessThan(500);
@@ -160,13 +162,15 @@ describe("native PDF provider API calls", () => {
     const error = await Promise.race([
       pdfNativeProviders
         .anthropicAnalyzePdf(makeAnthropicAnalyzeParams())
-        .catch((caught: unknown) => caught as Error),
+        .catch((caught: unknown) => caught),
       new Promise<Error>((_resolve, reject) => {
         setTimeout(() => reject(new Error("timed out waiting for bounded error body")), 500);
       }),
     ]);
 
-    expect(error).toBeInstanceOf(Error);
+    if (!(error instanceof Error)) {
+      throw new Error("expected Anthropic PDF request to throw an Error");
+    }
     expect(error.message).toContain("Anthropic PDF request failed");
     expect(canceled).toBe(true);
   });
