fix(workboard): preserve created status from stale lifecycle

BunsDev · BunsDev · commit 3bd0e2da5d93 · 2026-06-03T04:44:16.000-07:00
diff --git a/extensions/workboard/src/store.test.ts b/extensions/workboard/src/store.test.ts
@@ -392,6 +392,35 @@ describe("WorkboardStore", () => {
     );
   });
 
+  it("keeps creation status from stale lifecycle patches", async () => {
+    vi.useFakeTimers();
+    try {
+      vi.setSystemTime(2000);
+      const store = new WorkboardStore(createMemoryStore());
+      const card = await store.create({
+        title: "Initial running status",
+        status: "running",
+      });
+
+      const staleLifecycle = await store.update(card.id, {
+        status: "review",
+        metadata: { lifecycleStatusSourceUpdatedAt: 1000 },
+      });
+      expect(staleLifecycle).toEqual(card);
+      expect(staleLifecycle.status).toBe("running");
+      expect(staleLifecycle.metadata?.lifecycleStatusSourceUpdatedAt).toBeUndefined();
+
+      const freshLifecycle = await store.update(card.id, {
+        status: "review",
+        metadata: { lifecycleStatusSourceUpdatedAt: 3000 },
+      });
+      expect(freshLifecycle.status).toBe("review");
+      expect(freshLifecycle.metadata?.lifecycleStatusSourceUpdatedAt).toBe(3000);
+    } finally {
+      vi.useRealTimers();
+    }
+  });
+
   it("keeps non-status fields from stale lifecycle patches", async () => {
     const store = new WorkboardStore(createMemoryStore());
     const card = await store.create({
diff --git a/extensions/workboard/src/store.ts b/extensions/workboard/src/store.ts
@@ -1662,8 +1662,9 @@ function latestStatusTransitionAt(card: WorkboardCard): number | undefined {
   for (let index = (card.events?.length ?? 0) - 1; index >= 0; index -= 1) {
     const event = card.events?.[index];
     if (
-      event?.kind === "moved" &&
-      event.fromStatus !== event.toStatus &&
+      (event?.kind === "moved" || event?.kind === "created") &&
+      ((event.kind === "created" && card.status !== "todo") ||
+        (event.kind === "moved" && event.fromStatus !== event.toStatus)) &&
       event.toStatus === card.status &&
       typeof event.at === "number" &&
       Number.isFinite(event.at)
diff --git a/ui/src/ui/controllers/workboard.test.ts b/ui/src/ui/controllers/workboard.test.ts
@@ -2141,6 +2141,43 @@ describe("workboard controller", () => {
     expect(state.cards.find((card) => card.id === "card-review")?.status).toBe("review");
   });
 
+  it("does not sync stale linked-session status over a card creation status", async () => {
+    const host = {};
+    const state = getWorkboardState(host);
+    state.loaded = true;
+    state.cards = [
+      {
+        ...sampleCard,
+        status: "running",
+        sessionKey: sampleSession.key,
+        createdAt: 2000,
+        updatedAt: 2000,
+        events: [{ id: "event-created", kind: "created", at: 2000, toStatus: "running" }],
+      },
+    ];
+    const client = createClient({
+      "workboard.cards.update": {
+        card: { ...sampleCard, status: "review", sessionKey: sampleSession.key },
+      },
+    });
+
+    await syncWorkboardLifecycle({
+      host,
+      client: client as never,
+      sessions: [
+        {
+          ...sampleSession,
+          status: "done",
+          hasActiveRun: false,
+          updatedAt: 1000,
+        },
+      ],
+    });
+
+    expect(client.request).not.toHaveBeenCalled();
+    expect(state.cards[0]?.status).toBe("running");
+  });
+
   it("does not sync linked card status from sessions without lifecycle provenance", async () => {
     const host = {};
     const state = getWorkboardState(host);
diff --git a/ui/src/ui/controllers/workboard.ts b/ui/src/ui/controllers/workboard.ts
@@ -1454,8 +1454,9 @@ function latestStatusTransitionAt(card: WorkboardCard): number | undefined {
   for (let index = (card.events?.length ?? 0) - 1; index >= 0; index -= 1) {
     const event = card.events?.[index];
     if (
-      event?.kind === "moved" &&
-      event.fromStatus !== event.toStatus &&
+      (event?.kind === "moved" || event?.kind === "created") &&
+      ((event.kind === "created" && card.status !== "todo") ||
+        (event.kind === "moved" && event.fromStatus !== event.toStatus)) &&
       event.toStatus === card.status &&
       typeof event.at === "number" &&
       Number.isFinite(event.at)
