fix(memory): trim reserved ID check, verbose/diagnostics in --shared path, guard sync no-op

Ubuntu · rendrag-git · commit 35b27aa65a1f · 2026-03-16T15:42:35.000-04:00
diff --git a/src/cli/memory-cli.ts b/src/cli/memory-cli.ts
@@ -631,22 +631,27 @@ export function registerMemoryCli(program: Command) {
     .option("--shared", "Index only the shared memory store", false)
     .option("--verbose", "Verbose logging", false)
     .action(async (opts: MemoryCommandOptions & { shared?: boolean }) => {
+      setVerbose(Boolean(opts.verbose));
       // Handle --shared: sync only the shared store
       if (opts.shared) {
         const { SHARED_AGENT_ID } = await import("../memory/shared-constants.js");
-        const { config: cfg } = await loadMemoryCommandConfig("memory index");
+        const { config: cfg, diagnostics } = await loadMemoryCommandConfig("memory index");
+        emitMemorySecretResolveDiagnostics(diagnostics);
         await withMemoryManagerForAgent({
           cfg,
           agentId: SHARED_AGENT_ID,
           run: async (manager) => {
+            if (!manager.sync) {
+              defaultRuntime.log("Shared store sync not available.");
+              return;
+            }
             defaultRuntime.log("Syncing shared memory store…");
-            await manager.sync?.({ reason: "cli", force: Boolean(opts.force) });
+            await manager.sync({ reason: "cli", force: Boolean(opts.force) });
             defaultRuntime.log("Shared store synced.");
           },
         });
         return;
       }
-      setVerbose(Boolean(opts.verbose));
       const { config: cfg, diagnostics } = await loadMemoryCommandConfig("memory index");
       emitMemorySecretResolveDiagnostics(diagnostics);
       const agentIds = resolveAgentIds(cfg, opts.agent);
diff --git a/src/config/zod-schema.agent-runtime.ts b/src/config/zod-schema.agent-runtime.ts
@@ -782,7 +782,7 @@ export const RESERVED_AGENT_IDS = new Set([SHARED_AGENT_ID]);
 
 export const AgentEntrySchema = z
   .object({
-    id: z.string().refine((id) => !RESERVED_AGENT_IDS.has(id.toLowerCase()), {
+    id: z.string().refine((id) => !RESERVED_AGENT_IDS.has(id.trim().toLowerCase()), {
       message: 'Agent ID "_shared" is reserved for the shared memory store',
     }),
     default: z.boolean().optional(),
