fix(config): keep channel validation hints generic

Gio Della-Libera · Gio Della-Libera · commit 357a224da31a · 2026-05-18T14:10:46.000-07:00
diff --git a/src/config/validation.channel-metadata.test.ts b/src/config/validation.channel-metadata.test.ts
@@ -247,7 +247,7 @@ describe("validateConfigObjectRawWithPlugins channel metadata", () => {
     expect(result.ok).toBe(true);
   });
 
-  it("explains the Telegram groups object-map shape when raw channel validation rejects it", () => {
+  it("keeps raw channel validation diagnostics plugin-agnostic", () => {
     const result = validateConfigObjectRawWithPlugins({
       channels: {
         telegram: {
@@ -261,13 +261,11 @@ describe("validateConfigObjectRawWithPlugins channel metadata", () => {
       expect(result.issues).toContainEqual(
         expect.objectContaining({
           path: "channels.telegram.groups",
-          message: expect.stringContaining(
-            "Telegram groups must be an object map keyed by Telegram group/chat id",
-          ),
+          message: expect.stringContaining("invalid config:"),
         }),
       );
-      expect(result.issues[0]?.message).toContain("topics");
-      expect(result.issues[0]?.message).toContain("openclaw doctor --fix");
+      expect(result.issues[0]?.message).not.toContain("Telegram groups");
+      expect(result.issues[0]?.message).not.toContain("openclaw doctor --fix");
     }
   });
 });
diff --git a/src/config/validation.ts b/src/config/validation.ts
@@ -85,8 +85,6 @@ function stripPreservedLegacyRootKeysForValidation(
 
 const CUSTOM_EXPECTED_ONE_OF_RE = /expected one of ((?:"[^"]+"(?:\|"?[^"]+"?)*)+)/i;
 const SECRETREF_POLICY_DOC_URL = "https://docs.openclaw.ai/reference/secretref-credential-surface";
-const TELEGRAM_GROUPS_SHAPE_HINT =
-  'Telegram groups must be an object map keyed by Telegram group/chat id, for example channels.telegram.groups."-1001234567890".topics."99" for forum topic routing. Do not use an array, string, or null for channels.telegram.groups; fix the shape, then rerun openclaw doctor --fix for any remaining Telegram config cleanup.';
 const bundledChannelSchemaById = new Map<string, unknown>(
   GENERATED_BUNDLED_CHANNEL_CONFIG_METADATA.map(
     (entry) => [entry.channelId, entry.schema] as const,
@@ -227,22 +225,8 @@ function collectAllowedValuesFromBundledChannelSchemaPath(
   return collectAllowedValuesFromJsonSchemaNode(targetNode);
 }
 
-function isTelegramGroupsConfigPath(path: string): boolean {
-  return (
-    path === "channels.telegram.groups" ||
-    /^channels\.telegram\.accounts\.[^.]+\.groups$/.test(path)
-  );
-}
-
-function appendTelegramGroupsShapeHint(path: string, message: string): string {
-  if (!isTelegramGroupsConfigPath(path) || message.includes(TELEGRAM_GROUPS_SHAPE_HINT)) {
-    return message;
-  }
-  return `${message}. ${TELEGRAM_GROUPS_SHAPE_HINT}`;
-}
-
-function formatRawChannelConfigIssueMessage(params: { path: string; message: string }): string {
-  return appendTelegramGroupsShapeHint(params.path, `invalid config: ${params.message}`);
+function formatRawChannelConfigIssueMessage(message: string): string {
+  return `invalid config: ${message}`;
 }
 function collectRawBundledChannelConfigIssues(config: OpenClawConfig): ConfigValidationIssue[] {
   if (!config.channels || !isRecord(config.channels)) {
@@ -270,7 +254,7 @@ function collectRawBundledChannelConfigIssues(config: OpenClawConfig): ConfigVal
         error.path === "<root>" ? `channels.${channelId}` : `channels.${channelId}.${error.path}`;
       issues.push({
         path,
-        message: formatRawChannelConfigIssueMessage({ path, message }),
+        message: formatRawChannelConfigIssueMessage(message),
         allowedValues: error.allowedValues,
         allowedValuesHiddenCount: error.allowedValuesHiddenCount,
       });
@@ -575,14 +559,13 @@ function mapZodIssueToConfigIssue(issue: unknown): ConfigValidationIssue {
     }
   }
 
-  const messageWithShapeHint = appendTelegramGroupsShapeHint(path, message);
   if (!allowedValuesSummary) {
-    return { path, message: messageWithShapeHint };
+    return { path, message };
   }
 
   return {
     path,
-    message: appendAllowedValuesHint(messageWithShapeHint, allowedValuesSummary),
+    message: appendAllowedValuesHint(message, allowedValuesSummary),
     allowedValues: allowedValuesSummary.values,
     allowedValuesHiddenCount: allowedValuesSummary.hiddenCount,
   };
@@ -1341,7 +1324,7 @@ function validateConfigObjectWithPluginsBase(
             error.path === "<root>" ? `channels.${trimmed}` : `channels.${trimmed}.${error.path}`;
           issues.push({
             path,
-            message: formatRawChannelConfigIssueMessage({ path, message: error.message }),
+            message: formatRawChannelConfigIssueMessage(error.message),
             allowedValues: error.allowedValues,
             allowedValuesHiddenCount: error.allowedValuesHiddenCount,
           });
