fix(test): avoid scanning static asset metadata

vincentkoc · vincentkoc · commit 3064d6181d18 · 2026-05-16T09:26:56.000+08:00
diff --git a/scripts/lib/static-extension-assets.mjs b/scripts/lib/static-extension-assets.mjs
@@ -1,3 +1,4 @@
+import { spawnSync } from "node:child_process";
 import fs from "node:fs";
 import path from "node:path";
 
@@ -19,7 +20,46 @@ function normalizePackageRelativePath(value) {
   return normalized;
 }
 
+function listTrackedExtensionPackageDirs(rootDir, fsImpl) {
+  if (fsImpl !== fs) {
+    return null;
+  }
+  const result = spawnSync("git", ["ls-files", "--", ":(glob)extensions/*/package.json"], {
+    cwd: rootDir,
+    encoding: "utf8",
+    stdio: ["ignore", "pipe", "ignore"],
+  });
+  if (result.status !== 0) {
+    return null;
+  }
+  return result.stdout
+    .split("\n")
+    .map((line) => toPosixPath(line.trim()))
+    .filter((line) => line.length > 0)
+    .flatMap((line) => {
+      const match = /^extensions\/([^/]+)\/package\.json$/u.exec(line);
+      if (!match?.[1]) {
+        return [];
+      }
+      const packageDir = path.join(rootDir, "extensions", match[1]);
+      return [
+        {
+          dirName: match[1],
+          hasPackageJson: true,
+          packageDir,
+          packageJsonPath: path.join(packageDir, "package.json"),
+        },
+      ];
+    })
+    .toSorted((left, right) => left.dirName.localeCompare(right.dirName));
+}
+
 function listExtensionPackageDirs(rootDir, fsImpl) {
+  const trackedDirs = listTrackedExtensionPackageDirs(rootDir, fsImpl);
+  if (trackedDirs) {
+    return trackedDirs;
+  }
+
   const extensionsRoot = path.join(rootDir, "extensions");
   if (!fsImpl.existsSync(extensionsRoot)) {
     return [];
@@ -29,7 +69,9 @@ function listExtensionPackageDirs(rootDir, fsImpl) {
     .filter((entry) => entry.isDirectory())
     .map((entry) => ({
       dirName: entry.name,
+      hasPackageJson: undefined,
       packageDir: path.join(extensionsRoot, entry.name),
+      packageJsonPath: path.join(extensionsRoot, entry.name, "package.json"),
     }))
     .toSorted((left, right) => left.dirName.localeCompare(right.dirName));
 }
@@ -58,9 +100,11 @@ export function discoverStaticExtensionAssets(params = {}) {
   const rootDir = params.rootDir ?? process.cwd();
   const fsImpl = params.fs ?? fs;
   const assets = [];
-  for (const { dirName, packageDir } of listExtensionPackageDirs(rootDir, fsImpl)) {
-    const packageJsonPath = path.join(packageDir, "package.json");
-    if (!fsImpl.existsSync(packageJsonPath)) {
+  for (const { dirName, hasPackageJson, packageJsonPath } of listExtensionPackageDirs(
+    rootDir,
+    fsImpl,
+  )) {
+    if (!(hasPackageJson ?? fsImpl.existsSync(packageJsonPath))) {
       continue;
     }
     const packageJson = readJsonFile(packageJsonPath, fsImpl);
diff --git a/test/scripts/runtime-postbuild.test.ts b/test/scripts/runtime-postbuild.test.ts
@@ -1,3 +1,4 @@
+import { execFileSync } from "node:child_process";
 import fs from "node:fs/promises";
 import path from "node:path";
 import { describe, expect, it, vi } from "vitest";
@@ -42,6 +43,56 @@ describe("runtime postbuild static assets", () => {
     ]);
   });
 
+  it("discovers repo static asset metadata without scanning extension directories", () => {
+    const output = execFileSync(
+      process.execPath,
+      [
+        "--input-type=module",
+        "--eval",
+        `
+          import fs from "node:fs";
+          import { syncBuiltinESMExports } from "node:module";
+          const counts = { existsSync: 0, readdirSync: 0 };
+          const originalExistsSync = fs.existsSync;
+          const originalReaddirSync = fs.readdirSync;
+          fs.existsSync = (...args) => {
+            counts.existsSync += 1;
+            return originalExistsSync(...args);
+          };
+          fs.readdirSync = (...args) => {
+            counts.readdirSync += 1;
+            return originalReaddirSync(...args);
+          };
+          syncBuiltinESMExports();
+          const assets = await import("./scripts/lib/static-extension-assets.mjs");
+          console.log(JSON.stringify({
+            counts,
+            outputs: assets.listStaticExtensionAssetOutputs(),
+            sources: assets.listStaticExtensionAssetSources(),
+          }));
+        `,
+      ],
+      {
+        cwd: process.cwd(),
+        encoding: "utf8",
+      },
+    );
+    const payload = JSON.parse(output) as {
+      counts: { existsSync: number; readdirSync: number };
+      outputs: string[];
+      sources: string[];
+    };
+
+    expect(payload.outputs).toEqual([
+      "dist/extensions/acpx/error-format.mjs",
+      "dist/extensions/acpx/mcp-command-line.mjs",
+      "dist/extensions/acpx/mcp-proxy.mjs",
+      "dist/extensions/diffs/assets/viewer-runtime.js",
+    ]);
+    expect(payload.sources).toContain("extensions/diffs/assets/viewer-runtime.js");
+    expect(payload.counts).toEqual({ existsSync: 0, readdirSync: 0 });
+  });
+
   it("discovers static assets from plugin package metadata", async () => {
     const rootDir = createTempDir("openclaw-runtime-postbuild-");
     const packageDir = path.join(rootDir, "extensions", "demo");
