fix(slack): keep downloaded files out of reply media (#86318)

neeravmakwana · cursoragent · web-flow · commit 2fcd48127606 · 2026-05-25T11:00:12.000+01:00
Co-authored-by: Cursor &lt;cursoragent@cursor.com&gt;
diff --git a/extensions/slack/src/action-runtime.test.ts b/extensions/slack/src/action-runtime.test.ts
@@ -448,6 +448,7 @@ describe("handleSlackAction", () => {
     });
     expect(details.media).toEqual({
       mediaUrl: "/tmp/openclaw-media/report.pdf",
+      outbound: false,
       contentType: "application/pdf",
     });
   });
diff --git a/extensions/slack/src/action-runtime.ts b/extensions/slack/src/action-runtime.ts
@@ -492,6 +492,7 @@ export async function handleSlackAction(
             placeholder: downloaded.placeholder,
             media: {
               mediaUrl: downloaded.path,
+              outbound: false,
               ...(downloaded.contentType ? { contentType: downloaded.contentType } : {}),
             },
           });
@@ -504,6 +505,7 @@ export async function handleSlackAction(
             fileId,
             path: downloaded.path,
             ...(downloaded.contentType ? { contentType: downloaded.contentType } : {}),
+            media: { outbound: false },
           },
         });
       }
diff --git a/src/agents/pi-embedded-subscribe.handlers.tools.media.test.ts b/src/agents/pi-embedded-subscribe.handlers.tools.media.test.ts
@@ -664,6 +664,61 @@ describe("handleToolExecutionEnd media emission", () => {
     expect(ctx.state.pendingToolTrustedLocalMedia).toBe(true);
   });
 
+  it("does NOT queue structured media marked as non-outbound", async () => {
+    const ctx = createMockContext({
+      shouldEmitToolOutput: false,
+      onToolResult: vi.fn(),
+      builtinToolNames: new Set(["message"]),
+    });
+
+    await handleToolExecutionEnd(ctx, {
+      type: "tool_execution_end",
+      toolName: "message",
+      toolCallId: "tc-1",
+      isError: false,
+      result: {
+        content: [{ type: "text", text: "Downloaded Slack file to /tmp/report.pdf" }],
+        details: {
+          media: {
+            mediaUrl: "/tmp/report.pdf",
+            outbound: false,
+          },
+        },
+      },
+    });
+
+    expect(ctx.state.pendingToolMediaUrls).toStrictEqual([]);
+  });
+
+  it("does NOT queue image fallback paths when media is marked as non-outbound", async () => {
+    const ctx = createMockContext({
+      shouldEmitToolOutput: false,
+      onToolResult: vi.fn(),
+      builtinToolNames: new Set(["message"]),
+    });
+
+    await handleToolExecutionEnd(ctx, {
+      type: "tool_execution_end",
+      toolName: "message",
+      toolCallId: "tc-1",
+      isError: false,
+      result: {
+        content: [
+          { type: "text", text: "Downloaded Slack image" },
+          { type: "image", data: "base64", mimeType: "image/png" },
+        ],
+        details: {
+          path: "/tmp/slack-image.png",
+          media: {
+            outbound: false,
+          },
+        },
+      },
+    });
+
+    expect(ctx.state.pendingToolMediaUrls).toStrictEqual([]);
+  });
+
   it("queues trusted TTS local media when the exact built-in name is absent", async () => {
     const ctx = createMockContext({
       shouldEmitToolOutput: false,
diff --git a/src/agents/pi-embedded-subscribe.tools.ts b/src/agents/pi-embedded-subscribe.tools.ts
@@ -463,6 +463,10 @@ function collectStructuredMediaUrls(media: Record<string, unknown>): string[] {
   return Array.from(new Set(urls));
 }
 
+function isNonOutboundToolResultMedia(media: Record<string, unknown>): boolean {
+  return media.outbound === false;
+}
+
 function extractTextContentMediaArtifact(content: unknown[]): {
   mediaUrls: string[];
   audioAsVoice?: boolean;
@@ -510,6 +514,9 @@ export function extractToolResultMediaArtifact(
   const record = result as Record<string, unknown>;
   const detailsMedia = readToolResultDetailsMedia(record);
   if (detailsMedia) {
+    if (isNonOutboundToolResultMedia(detailsMedia)) {
+      return undefined;
+    }
     const mediaUrls = collectStructuredMediaUrls(detailsMedia);
     if (mediaUrls.length > 0) {
       return {
