fix: parse qa transport timeout env strictly

steipete · steipete · commit 2e8b3445fb0a · 2026-05-28T13:53:18.000-04:00
diff --git a/extensions/qa-lab/src/suite.test.ts b/extensions/qa-lab/src/suite.test.ts
@@ -108,6 +108,13 @@ describe("qa suite", () => {
         OPENCLAW_QA_TRANSPORT_READY_TIMEOUT_MS: "bad",
       }),
     ).toBe(120_000);
+    for (const value of ["0x10", "1e3", "10.5"]) {
+      expect(
+        qaSuiteProgressTesting.resolveQaSuiteTransportReadyTimeoutMs(undefined, {
+          OPENCLAW_QA_TRANSPORT_READY_TIMEOUT_MS: value,
+        }),
+      ).toBe(120_000);
+    }
     expect(qaSuiteProgressTesting.resolveQaSuiteTransportReadyTimeoutMs(90_000, {})).toBe(90_000);
   });
 
diff --git a/extensions/qa-lab/src/suite.ts b/extensions/qa-lab/src/suite.ts
@@ -4,6 +4,7 @@ import { setTimeout as sleep } from "node:timers/promises";
 import { disposeRegisteredAgentHarnesses } from "openclaw/plugin-sdk/agent-harness";
 import type { OpenClawConfig } from "openclaw/plugin-sdk/config-contracts";
 import { formatErrorMessage } from "openclaw/plugin-sdk/error-runtime";
+import { parseStrictPositiveInteger } from "openclaw/plugin-sdk/number-runtime";
 import {
   renderQaMarkdownReport,
   type QaReportCheck,
@@ -152,11 +153,11 @@ function resolveQaSuiteTransportReadyTimeoutMs(
   if (!raw) {
     return 120_000;
   }
-  const parsed = Number(raw);
-  if (!Number.isFinite(parsed) || parsed < 1) {
+  const parsed = parseStrictPositiveInteger(raw);
+  if (parsed === undefined) {
     return 120_000;
   }
-  return Math.floor(parsed);
+  return parsed;
 }
 
 function writeQaSuiteProgress(enabled: boolean, message: string) {
