test(perf): bound google meet retry waits

steipete · steipete · commit 2e10ffe8130d · 2026-05-06T15:25:23.000+01:00
diff --git a/extensions/google-meet/index.test.ts b/extensions/google-meet/index.test.ts
@@ -2885,11 +2885,14 @@ describe("google-meet plugin", () => {
           }) => Promise<void>)
         | undefined;
       const respond = vi.fn();
+      vi.useFakeTimers();
 
-      await handler?.({
+      const run = handler?.({
         params: { url: "https://meet.google.com/abc-defg-hij" },
         respond,
       });
+      await vi.advanceTimersByTimeAsync(2_000);
+      await run;
 
       expect(respond.mock.calls[0]?.[1]).toMatchObject({
         spoken: false,
@@ -2905,6 +2908,7 @@ describe("google-meet plugin", () => {
       });
       expect(inspectCount).toBeGreaterThanOrEqual(2);
     } finally {
+      vi.useRealTimers();
       Object.defineProperty(process, "platform", { value: originalPlatform });
     }
   });
@@ -4831,6 +4835,7 @@ describe("google-meet plugin", () => {
   });
 
   it("stops paired-node realtime audio after repeated input pull failures", async () => {
+    vi.useFakeTimers();
     const bridge = {
       connect: vi.fn(async () => {}),
       sendAudio: vi.fn(),
@@ -4860,38 +4865,42 @@ describe("google-meet plugin", () => {
       },
     };
 
-    const handle = await startNodeRealtimeAudioBridge({
-      config: resolveGoogleMeetConfig({
-        realtime: { provider: "openai", model: "gpt-realtime" },
-      }),
-      fullConfig: {} as never,
-      runtime: runtime as never,
-      meetingSessionId: "meet-1",
-      nodeId: "node-1",
-      bridgeId: "bridge-1",
-      logger: noopLogger,
-      providers: [provider],
-    });
-
-    await vi.waitFor(
-      () => {
-        expect(bridge.close).toHaveBeenCalled();
-      },
-      { timeout: 3_000 },
-    );
-    expect(handle.getHealth()).toMatchObject({
-      bridgeClosed: true,
-      consecutiveInputErrors: 5,
-      lastInputError: "node invoke timeout",
-    });
-    expect(runtime.nodes.invoke).toHaveBeenCalledWith(
-      expect.objectContaining({
+    try {
+      const handle = await startNodeRealtimeAudioBridge({
+        config: resolveGoogleMeetConfig({
+          realtime: { provider: "openai", model: "gpt-realtime" },
+        }),
+        fullConfig: {} as never,
+        runtime: runtime as never,
+        meetingSessionId: "meet-1",
         nodeId: "node-1",
-        command: "googlemeet.chrome",
-        params: { action: "stop", bridgeId: "bridge-1" },
-        timeoutMs: 5_000,
-      }),
-    );
+        bridgeId: "bridge-1",
+        logger: noopLogger,
+        providers: [provider],
+      });
+
+      await vi.waitFor(
+        () => {
+          expect(bridge.close).toHaveBeenCalled();
+        },
+        { timeout: 3_000 },
+      );
+      expect(handle.getHealth()).toMatchObject({
+        bridgeClosed: true,
+        consecutiveInputErrors: 5,
+        lastInputError: "node invoke timeout",
+      });
+      expect(runtime.nodes.invoke).toHaveBeenCalledWith(
+        expect.objectContaining({
+          nodeId: "node-1",
+          command: "googlemeet.chrome",
+          params: { action: "stop", bridgeId: "bridge-1" },
+          timeoutMs: 5_000,
+        }),
+      );
+    } finally {
+      vi.useRealTimers();
+    }
   });
 
   it("exposes node-host list and stop-by-url bridge actions", async () => {
diff --git a/extensions/google-meet/src/runtime.ts b/extensions/google-meet/src/runtime.ts
@@ -634,7 +634,7 @@ export class GoogleMeetRuntime {
     );
     const deadline = Date.now() + waitMs;
     while (Date.now() < deadline) {
-      await sleep(250);
+      await sleep(Math.min(250, Math.max(0, deadline - Date.now())));
       result = await this.speak(session.id, instructions);
       if (result.spoken) {
         return true;
diff --git a/extensions/google-meet/src/transports/chrome.ts b/extensions/google-meet/src/transports/chrome.ts
@@ -753,10 +753,11 @@ async function openMeetWithBrowserRequest(params: {
       };
       break;
     }
-    if (Date.now() <= deadline) {
-      await new Promise((resolve) => setTimeout(resolve, 750));
+    const remainingWaitMs = deadline - Date.now();
+    if (remainingWaitMs > 0) {
+      await new Promise((resolve) => setTimeout(resolve, Math.min(750, remainingWaitMs)));
     }
-  } while (Date.now() <= deadline);
+  } while (Date.now() < deadline);
   return { launched: true, browser };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -753,10 +753,11 @@ async function openMeetWithBrowserRequest(params: {`
`753`	`753`	`};`
`754`	`754`	`break;`
`755`	`755`	`}`
`756`		`- if (Date.now() <= deadline) {`
`757`		`- await new Promise((resolve) => setTimeout(resolve, 750));`
	`756`	`+ const remainingWaitMs = deadline - Date.now();`
	`757`	`+ if (remainingWaitMs > 0) {`
	`758`	`+ await new Promise((resolve) => setTimeout(resolve, Math.min(750, remainingWaitMs)));`
`758`	`759`	`}`
`759`		`- } while (Date.now() <= deadline);`
	`760`	`+ } while (Date.now() < deadline);`
`760`	`761`	`return { launched: true, browser };`
`761`	`762`	`}`
`762`	`763`