fix(twitch): export clearRegistryForTest for cross-test isolation (#83887)

HCL · HCL · commit 297274d48006 · 2026-05-20T01:38:38.000+08:00
`client-manager-registry.ts` holds a module-level `Map&lt;accountId,
RegistryEntry&gt;` for `getOrCreateClientManager`. `TwitchClientManager`
in the sibling module already acknowledges that module-level state
needs a test escape hatch (`clearForTest`), but the registry lacks
the equivalent. Under vitest `--isolate=false` (or any harness that
keeps the module graph hot across tests) a test that calls
`getOrCreateClientManager('default', loggerA)` leaves its entry
behind, and the next test calling the same factory silently gets
loggerA's manager — chasing a phantom mock-assertion bug becomes
the failure mode.

Add an exported `clearRegistryForTest()` that calls `registry.clear()`,
mirroring `TwitchClientManager.clearForTest`. No production behavior
change — production code never calls this.
diff --git a/extensions/twitch/src/client-manager-registry.ts b/extensions/twitch/src/client-manager-registry.ts
@@ -85,3 +85,20 @@ export async function removeClientManager(accountId: string): Promise<void> {
   registry.delete(accountId);
   entry.logger.info(`Unregistered client manager for account: ${accountId}`);
 }
+
+/**
+ * Test-only: clear the module-level registry of all client manager entries.
+ *
+ * Mirrors the `clearForTest` escape hatch on `TwitchClientManager`. Without
+ * this, the module-level `registry` Map survives across tests when vitest
+ * is run with `--isolate=false` (or any harness that does not tear the
+ * module graph down between cases), and a stale entry from one test will
+ * shadow `getOrCreateClientManager` calls in subsequent tests — silently
+ * handing back another test's mocked logger/manager. See #83887.
+ *
+ * Production code MUST NOT call this. It is safe to call when the registry
+ * is empty (clear() is a no-op on an empty Map).
+ */
+export function clearRegistryForTest(): void {
+  registry.clear();
+}
