fix(codex): ignore invalid history timestamps

steipete · steipete · commit 28eb4cfa12e5 · 2026-05-30T05:28:14.000-04:00
diff --git a/extensions/codex/src/node-cli-sessions.test.ts b/extensions/codex/src/node-cli-sessions.test.ts
@@ -75,6 +75,35 @@ describe("codex cli node sessions", () => {
     ]);
   });
 
+  it("ignores Date-invalid Codex history timestamps", async () => {
+    const sessionId = "019e2007-1f7e-7eb1-a42b-8c01f4b9b5cf";
+    await fs.writeFile(
+      path.join(tempDir, "history.jsonl"),
+      JSON.stringify({ session_id: sessionId, ts: 8_700_000_000_000, text: "bad timestamp" }),
+    );
+
+    const command = createCodexCliSessionNodeHostCommands().find(
+      (entry) => entry.command === CODEX_CLI_SESSIONS_LIST_COMMAND,
+    );
+    const raw = await command?.handle(JSON.stringify({ filter: "bad timestamp", limit: 5 }));
+    const parsed = JSON.parse(raw ?? "{}") as {
+      sessions?: Array<{
+        sessionId?: string;
+        updatedAt?: string;
+        lastMessage?: string;
+        messageCount?: number;
+      }>;
+    };
+
+    expect(parsed.sessions).toEqual([
+      {
+        sessionId,
+        lastMessage: "bad timestamp",
+        messageCount: 1,
+      },
+    ]);
+  });
+
   it("lists sessions from Codex session files when history is absent", async () => {
     const sessionId = "019e23d1-f33d-78e3-959e-0f56f30a5249";
     const sessionDir = path.join(tempDir, "sessions", "2026", "05", "14");
diff --git a/extensions/codex/src/node-cli-sessions.ts b/extensions/codex/src/node-cli-sessions.ts
@@ -3,6 +3,7 @@ import fs from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
 import process from "node:process";
+import { timestampMsToIsoString } from "openclaw/plugin-sdk/number-runtime";
 import type {
   OpenClawPluginNodeHostCommand,
   OpenClawPluginNodeInvokePolicy,
@@ -371,8 +372,8 @@ async function readHistorySessions(
     if (typeof parsed.text === "string" && parsed.text.trim()) {
       entry.lastMessage = truncateText(parsed.text.trim(), 140);
     }
-    if (typeof parsed.ts === "number" && Number.isFinite(parsed.ts)) {
-      entry.updatedAt = new Date(parsed.ts * 1000).toISOString();
+    if (typeof parsed.ts === "number") {
+      entry.updatedAt = timestampMsToIsoString(parsed.ts * 1000) ?? entry.updatedAt;
     }
     summaries.set(sessionId, entry);
   }
diff --git a/src/plugin-sdk/number-runtime.ts b/src/plugin-sdk/number-runtime.ts
@@ -22,6 +22,7 @@ export {
   parseStrictPositiveInteger,
   positiveSecondsToSafeMilliseconds,
   nonNegativeSecondsToSafeMilliseconds,
+  timestampMsToIsoString,
   resolveExpiresAtMsFromDurationSeconds,
   resolveExpiresAtMsFromDurationOrEpoch,
   resolveExpiresAtMsFromEpochSeconds,
diff --git a/src/shared/number-coercion.test.ts b/src/shared/number-coercion.test.ts
@@ -24,6 +24,7 @@ import {
   parseStrictNonNegativeInteger,
   parseStrictPositiveInteger,
   resolveTimerTimeoutMs,
+  timestampMsToIsoString,
 } from "./number-coercion.js";
 
 describe("number-coercion", () => {
@@ -117,6 +118,14 @@ describe("number-coercion", () => {
     expect(nonNegativeSecondsToSafeMilliseconds("-1")).toBeUndefined();
   });
 
+  test("timestamp ISO helper rejects Date-invalid timestamps", () => {
+    expect(timestampMsToIsoString(0)).toBe("1970-01-01T00:00:00.000Z");
+    expect(timestampMsToIsoString(8_640_000_000_000_000)).toBe("+275760-09-13T00:00:00.000Z");
+    expect(timestampMsToIsoString(8_640_000_000_000_001)).toBeUndefined();
+    expect(timestampMsToIsoString(Number.POSITIVE_INFINITY)).toBeUndefined();
+    expect(timestampMsToIsoString("0")).toBeUndefined();
+  });
+
   test("expiry helpers resolve safe absolute timestamps", () => {
     expect(
       resolveExpiresAtMsFromDurationSeconds("3600", {
diff --git a/src/shared/number-coercion.ts b/src/shared/number-coercion.ts
@@ -97,6 +97,14 @@ export const MAX_TIMER_TIMEOUT_MS = 2_147_000_000;
 export const MAX_TIMER_TIMEOUT_SECONDS = Math.floor(MAX_TIMER_TIMEOUT_MS / 1000);
 export const MAX_DATE_TIMESTAMP_MS = 8_640_000_000_000_000;
 
+export function timestampMsToIsoString(value: unknown): string | undefined {
+  const timestampMs = asFiniteNumberInRange(value, {
+    min: -MAX_DATE_TIMESTAMP_MS,
+    max: MAX_DATE_TIMESTAMP_MS,
+  });
+  return timestampMs === undefined ? undefined : new Date(timestampMs).toISOString();
+}
+
 export function clampTimerTimeoutMs(valueMs: unknown, minMs = 1): number | undefined {
   const value = asFiniteNumber(valueMs);
   if (value === undefined) {

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ import fs from "node:fs/promises";`
`3`	`3`	`import os from "node:os";`
`4`	`4`	`import path from "node:path";`
`5`	`5`	`import process from "node:process";`
	`6`	`+import { timestampMsToIsoString } from "openclaw/plugin-sdk/number-runtime";`
`6`	`7`	`import type {`
`7`	`8`	`OpenClawPluginNodeHostCommand,`
`8`	`9`	`OpenClawPluginNodeInvokePolicy,`
`@@ -371,8 +372,8 @@ async function readHistorySessions(`
`371`	`372`	`if (typeof parsed.text === "string" && parsed.text.trim()) {`
`372`	`373`	`entry.lastMessage = truncateText(parsed.text.trim(), 140);`
`373`	`374`	`}`
`374`		`- if (typeof parsed.ts === "number" && Number.isFinite(parsed.ts)) {`
`375`		`- entry.updatedAt = new Date(parsed.ts * 1000).toISOString();`
	`375`	`+ if (typeof parsed.ts === "number") {`
	`376`	`+ entry.updatedAt = timestampMsToIsoString(parsed.ts * 1000) ?? entry.updatedAt;`
`376`	`377`	`}`
`377`	`378`	`summaries.set(sessionId, entry);`
`378`	`379`	`}`