fix(installer): install portable Node directory atomically

steipete · steipete · commit 2890b1a24ab1 · 2026-05-22T14:36:50.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -61,6 +61,7 @@ Docs: https://docs.openclaw.ai
 - Plugins/discovery: strip `-plugin` package suffixes when deriving plugin id hints so package names line up with manifest ids. (#85170) Thanks @JulyanXu.
 - Telegram: preserve fenced code block languages through Markdown rendering so Telegram receives `language-*` code classes. (#85209) Thanks @leno23.
 - Windows installer: bootstrap a user-local portable Node.js when native Windows has no Node and no winget, Chocolatey, or Scoop, so first-run installs can continue on raw hosts.
+- Windows installer: install the downloaded portable Node.js directory atomically so PowerShell 5.1 first-run bootstraps do not fail while moving zip contents.
 - fix(integrations): enforce channel read target allowlists [AI]. (#84982) Thanks @pgondhi987.
 - Agents/heartbeat: route single-owner `session.dmScope=main` direct-message exec and cron event wakes back to the agent main session so async completions no longer strand context in orphan direct-DM queues. Fixes #71581. (#83743) Thanks @Kaspre.
 - Agents/code-mode: expose outer code-mode `exec` source through the `command` hook alias with `toolKind`/`toolInputKind` discriminators so exec-shaped policies can distinguish code-mode cells. (#83483) Thanks @Kaspre.
diff --git a/scripts/install.ps1 b/scripts/install.ps1
@@ -222,8 +222,7 @@ function Install-PortableNode {
             throw "Node.js archive did not contain node.exe."
         }
 
-        New-Item -ItemType Directory -Force -Path $portableRoot | Out-Null
-        Move-Item -Path (Join-Path $nodeDir.FullName "*") -Destination $portableRoot -Force
+        Move-Item -LiteralPath $nodeDir.FullName -Destination $portableRoot -Force
     } finally {
         if (Test-Path $tmpZip) {
             Remove-Item -Force $tmpZip
diff --git a/test/scripts/install-ps1.test.ts b/test/scripts/install-ps1.test.ts
@@ -128,8 +128,14 @@ describe("install.ps1 failure handling", () => {
     expect(depsRootBody).toContain("OpenClaw\\deps");
     expect(portableNodeBody).toContain("portable-node");
     expect(portableNodeBody).toContain("Ensure-PortableNodeOnUserPath");
+    expect(portableNodeBody).toContain(
+      "Move-Item -LiteralPath $nodeDir.FullName -Destination $portableRoot -Force",
+    );
+    expect(portableNodeBody).not.toContain('Join-Path $nodeDir.FullName "*"');
     expect(portableNodePathBody).toContain("Add-ToUserPath $nodeDir");
-    expect(userPathBody).toContain('[Environment]::SetEnvironmentVariable("Path", $newUserPath, "User")');
+    expect(userPathBody).toContain(
+      '[Environment]::SetEnvironmentVariable("Path", $newUserPath, "User")',
+    );
     expect(portableNodeBody).toContain("Invoke-WebRequest -UseBasicParsing");
     expect(resolveNodeBody).toContain("https://nodejs.org/dist/index.json");
     expect(resolveNodeBody).toContain("win-$architecture-zip");

Original file line number	Diff line number	Diff line change
`@@ -222,8 +222,7 @@ function Install-PortableNode {`
`222`	`222`	`throw "Node.js archive did not contain node.exe."`
`223`	`223`	`}`
`224`	`224`
`225`		`- New-Item -ItemType Directory -Force -Path $portableRoot \| Out-Null`
`226`		`- Move-Item -Path (Join-Path $nodeDir.FullName "*") -Destination $portableRoot -Force`
	`225`	`+ Move-Item -LiteralPath $nodeDir.FullName -Destination $portableRoot -Force`
`227`	`226`	`} finally {`
`228`	`227`	`if (Test-Path $tmpZip) {`
`229`	`228`	`Remove-Item -Force $tmpZip`