refactor: simplify channel setup conversions

steipete · steipete · commit 270630ba35e4 · 2026-04-11T01:11:05.000+01:00
diff --git a/extensions/feishu/src/channel.ts b/extensions/feishu/src/channel.ts
@@ -1058,7 +1058,7 @@ export const feishuPlugin: ChannelPlugin<ResolvedFeishuAccount, FeishuProbeResul
             return jsonActionResult({ ok: true, reactions });
           }
 
-          throw new Error(`Unsupported Feishu action: "${String(ctx.action)}"`);
+          throw new Error(`Unsupported Feishu action: "${ctx.action}"`);
         },
       },
       bindings: {
diff --git a/extensions/feishu/src/policy.ts b/extensions/feishu/src/policy.ts
@@ -42,7 +42,7 @@ export function resolveFeishuAllowlistMatch(params: {
 
   // Feishu allowlists are ID-based; mutable display names must never grant access.
   const senderCandidates = [params.senderId, ...(params.senderIds ?? [])]
-    .map((entry) => normalizeFeishuAllowEntry(String(entry ?? "")))
+    .map((entry) => normalizeFeishuAllowEntry(entry ?? ""))
     .filter(Boolean);
 
   for (const senderId of senderCandidates) {
diff --git a/extensions/feishu/src/send.ts b/extensions/feishu/src/send.ts
@@ -276,7 +276,7 @@ function parseFeishuMessageItem(
     senderType: item.sender?.sender_type,
     content: parseFeishuMessageContent(rawContent, msgType),
     contentType: msgType,
-    createTime: item.create_time ? parseInt(String(item.create_time), 10) : undefined,
+    createTime: item.create_time ? parseInt(item.create_time, 10) : undefined,
     threadId: item.thread_id || undefined,
   };
 }
diff --git a/extensions/firecrawl/src/firecrawl-client.ts b/extensions/firecrawl/src/firecrawl-client.ts
@@ -141,7 +141,7 @@ async function postFirecrawlJson<T>(
             detail = errorBody.text;
           }
         }
-        const safeDetail = wrapWebContent(String(detail).slice(0, 1_000), "web_fetch");
+        const safeDetail = wrapWebContent(detail.slice(0, 1_000), "web_fetch");
         throw new Error(`${params.errorLabel} API error (${response.status}): ${safeDetail}`);
       }
       return await parse(response);
diff --git a/extensions/msteams/src/monitor-handler/access.ts b/extensions/msteams/src/monitor-handler/access.ts
@@ -43,7 +43,7 @@ export async function resolveMSTeamsSenderAccess(params: {
     dmPolicy,
     readStore: pairing.readStoreForDmPolicy,
   });
-  const configuredDmAllowFrom = (msteamsCfg?.allowFrom ?? []).map((entry) => String(entry));
+  const configuredDmAllowFrom = msteamsCfg?.allowFrom ?? [];
   const groupAllowFrom = msteamsCfg?.groupAllowFrom;
   const resolvedAllowFromLists = resolveEffectiveAllowFromLists({
     allowFrom: configuredDmAllowFrom,
diff --git a/extensions/msteams/src/monitor.ts b/extensions/msteams/src/monitor.ts
@@ -103,17 +103,16 @@ export async function monitorMSTeamsProvider(
 
   try {
     const allowEntries =
-      allowFrom
-        ?.map((entry) => cleanAllowEntry(String(entry)))
-        .filter((entry) => entry && entry !== "*") ?? [];
+      allowFrom?.map((entry) => cleanAllowEntry(entry)).filter((entry) => entry && entry !== "*") ??
+      [];
     if (allowEntries.length > 0) {
       const { additions } = await resolveAllowlistUsers("msteams users", allowEntries);
       allowFrom = mergeAllowlist({ existing: allowFrom, additions });
     }
 
     if (Array.isArray(groupAllowFrom) && groupAllowFrom.length > 0) {
       const groupEntries = groupAllowFrom
-        .map((entry) => cleanAllowEntry(String(entry)))
+        .map((entry) => cleanAllowEntry(entry))
         .filter((entry) => entry && entry !== "*");
       if (groupEntries.length > 0) {
         const { additions } = await resolveAllowlistUsers("msteams group users", groupEntries);
diff --git a/extensions/nextcloud-talk/src/monitor.ts b/extensions/nextcloud-talk/src/monitor.ts
@@ -171,7 +171,7 @@ function payloadToInboundMessage(
   const isGroupChat = true;
 
   return {
-    messageId: String(payload.object.id),
+    messageId: payload.object.id,
     roomToken: payload.target.id,
     roomName: payload.target.name,
     senderId: payload.actor.id,
diff --git a/extensions/nextcloud-talk/src/setup-core.ts b/extensions/nextcloud-talk/src/setup-core.ts
@@ -123,7 +123,7 @@ async function promptNextcloudTalkAllowFrom(params: {
     message: "Nextcloud Talk allowFrom (user id)",
     placeholder: "username",
     parseEntries: (raw) => ({
-      entries: String(raw)
+      entries: raw
         .split(/[\n,;]+/g)
         .map(normalizeLowercaseStringOrEmpty)
         .filter(Boolean),
diff --git a/extensions/synology-chat/src/setup-surface.ts b/extensions/synology-chat/src/setup-surface.ts
@@ -127,12 +127,24 @@ function parseSynologyUserId(value: string): string | null {
   return /^\d+$/.test(cleaned) ? cleaned : null;
 }
 
+function normalizeSynologyAllowedUserId(value: unknown): string {
+  if (
+    typeof value === "string" ||
+    typeof value === "number" ||
+    typeof value === "boolean" ||
+    typeof value === "bigint"
+  ) {
+    return `${value}`.trim();
+  }
+  return "";
+}
+
 function resolveExistingAllowedUserIds(cfg: OpenClawConfig, accountId: string): string[] {
   const raw = getRawAccountConfig(cfg, accountId).allowedUserIds;
   if (Array.isArray(raw)) {
-    return raw.map((value) => String(value).trim()).filter(Boolean);
+    return raw.map(normalizeSynologyAllowedUserId).filter(Boolean);
   }
-  return String(raw ?? "")
+  return normalizeSynologyAllowedUserId(raw)
     .split(",")
     .map((value) => value.trim())
     .filter(Boolean);
diff --git a/extensions/tlon/src/setup-core.ts b/extensions/tlon/src/setup-core.ts
@@ -99,7 +99,7 @@ export function createTlonSetupWizardBase(params: TlonSetupWizardBaseParams): Ch
         placeholder: "https://your-ship-host",
         currentValue: ({ cfg, accountId }) => resolveTlonAccount(cfg, accountId).url ?? undefined,
         validate: ({ value }) => {
-          const next = validateUrbitBaseUrl(String(value ?? ""));
+          const next = validateUrbitBaseUrl(value ?? "");
           if (!next.ok) {
             return next.error;
           }
diff --git a/extensions/tlon/src/setup-surface.ts b/extensions/tlon/src/setup-surface.ts
@@ -66,7 +66,7 @@ export const tlonSetupWizard = createTlonSetupWizardBase({
       next = applyTlonSetupConfig({
         cfg: next,
         accountId,
-        input: { groupChannels: parseList(String(entry ?? "")) },
+        input: { groupChannels: parseList(entry ?? "") },
       });
     }
 
@@ -85,7 +85,7 @@ export const tlonSetupWizard = createTlonSetupWizardBase({
         cfg: next,
         accountId,
         input: {
-          dmAllowlist: parseList(String(entry ?? "")).map((ship) => normalizeShip(ship)),
+          dmAllowlist: parseList(entry ?? "").map((ship) => normalizeShip(ship)),
         },
       });
     }
diff --git a/extensions/tlon/src/urbit/base-url.ts b/extensions/tlon/src/urbit/base-url.ts
@@ -14,7 +14,7 @@ export function normalizeUrbitHostname(hostname: string | undefined): string {
 }
 
 export function validateUrbitBaseUrl(raw: string): UrbitBaseUrlValidation {
-  const trimmed = String(raw ?? "").trim();
+  const trimmed = raw.trim();
   if (!trimmed) {
     return { ok: false, error: "Required" };
   }
diff --git a/extensions/whatsapp/src/auto-reply/monitor/group-gating.ts b/extensions/whatsapp/src/auto-reply/monitor/group-gating.ts
@@ -171,8 +171,7 @@ export function applyGroupGating(params: ApplyGroupGatingParams) {
       commandAuthorized: false,
     },
   });
-  const effectiveWasMentioned =
-    mentionDecision.effectiveWasMentioned || Boolean(shouldBypassMention);
+  const effectiveWasMentioned = mentionDecision.effectiveWasMentioned || shouldBypassMention;
   params.msg.wasMentioned = effectiveWasMentioned;
   if (!shouldBypassMention && requireMention && mentionDecision.shouldSkip) {
     return skipGroupMessageAndStoreHistory(
diff --git a/extensions/whatsapp/src/auto-reply/monitor/inbound-context.ts b/extensions/whatsapp/src/auto-reply/monitor/inbound-context.ts
@@ -33,7 +33,7 @@ export function isWhatsAppSupplementalSenderAllowed(params: {
     return false;
   }
   for (const entry of params.allowFrom) {
-    const rawEntry = String(entry).trim();
+    const rawEntry = entry.trim();
     if (!rawEntry) {
       continue;
     }
diff --git a/extensions/whatsapp/src/auto-reply/monitor/process-message.ts b/extensions/whatsapp/src/auto-reply/monitor/process-message.ts
@@ -89,7 +89,7 @@ async function resolveWhatsAppCommandAuthorized(params: {
         return true;
       }
       const normalizedEntries = allowEntries
-        .map((entry) => normalizeE164(String(entry)))
+        .map((entry) => normalizeE164(entry))
         .filter((entry): entry is string => Boolean(entry));
       return normalizedEntries.includes(senderE164);
     },
diff --git a/extensions/whatsapp/src/inbound/access-control.ts b/extensions/whatsapp/src/inbound/access-control.ts
@@ -102,7 +102,7 @@ export async function checkInboundAccessControl(params: {
       }
       const normalizedEntrySet = new Set(
         allowEntries
-          .map((entry) => normalizeE164(String(entry)))
+          .map((entry) => normalizeE164(entry))
           .filter((entry): entry is string => Boolean(entry)),
       );
       if (!params.group && isSamePhone) {
diff --git a/extensions/whatsapp/src/inbound/monitor.ts b/extensions/whatsapp/src/inbound/monitor.ts
@@ -181,7 +181,7 @@ export async function monitorWebInbox(options: {
   const rememberOutboundMessage = (remoteJid: string, result: unknown) => {
     const messageId =
       typeof result === "object" && result && "key" in result
-        ? String((result as { key?: { id?: string } }).key?.id ?? "")
+        ? ((result as { key?: { id?: string } }).key?.id ?? "")
         : "";
     if (!messageId) {
       return;
diff --git a/extensions/whatsapp/src/inbound/send-api.ts b/extensions/whatsapp/src/inbound/send-api.ts
@@ -13,7 +13,7 @@ function recordWhatsAppOutbound(accountId: string) {
 
 function resolveOutboundMessageId(result: unknown): string {
   return typeof result === "object" && result && "key" in result
-    ? String((result as { key?: { id?: string } }).key?.id ?? "unknown")
+    ? ((result as { key?: { id?: string } }).key?.id ?? "unknown")
     : "unknown";
 }
 
diff --git a/extensions/whatsapp/src/security-fix.ts b/extensions/whatsapp/src/security-fix.ts
@@ -56,9 +56,7 @@ export async function applyWhatsAppSecurityConfigFixes(params: {
     params.env,
     DEFAULT_ACCOUNT_ID,
   ).catch(() => []);
-  const normalized = Array.from(new Set(fromStore.map((entry) => String(entry).trim()))).filter(
-    Boolean,
-  );
+  const normalized = Array.from(new Set(fromStore.map((entry) => entry.trim()))).filter(Boolean);
   if (normalized.length === 0) {
     return { config: params.cfg, changes: [] };
   }
diff --git a/extensions/whatsapp/src/setup-surface.ts b/extensions/whatsapp/src/setup-surface.ts
@@ -40,7 +40,7 @@ export const whatsappSetupWizard: ChannelSetupWizard = {
       return [`${label}: ${configured ? "linked" : "not linked"}`];
     },
   },
-  resolveShouldPromptAccountIds: ({ shouldPromptAccountIds }) => Boolean(shouldPromptAccountIds),
+  resolveShouldPromptAccountIds: ({ shouldPromptAccountIds }) => shouldPromptAccountIds,
   credentials: [],
   finalize: async ({ cfg, accountId, forceAllowFrom, prompter, runtime }) =>
     await finalizeWhatsAppSetup({ cfg, accountId, forceAllowFrom, prompter, runtime }),
diff --git a/extensions/whatsapp/src/shared.ts b/extensions/whatsapp/src/shared.ts
@@ -74,7 +74,7 @@ export function createWhatsAppSetupWizardProxy(
       configuredScore: 5,
       unconfiguredScore: 4,
     },
-    resolveShouldPromptAccountIds: (params) => Boolean(params.shouldPromptAccountIds),
+    resolveShouldPromptAccountIds: (params) => params.shouldPromptAccountIds,
     credentials: [],
     delegateFinalize: true,
     disable: (cfg) => ({

Original file line number	Diff line number	Diff line change
`@@ -1058,7 +1058,7 @@ export const feishuPlugin: ChannelPlugin<ResolvedFeishuAccount, FeishuProbeResul`
`1058`	`1058`	`return jsonActionResult({ ok: true, reactions });`
`1059`	`1059`	`}`
`1060`	`1060`
`1061`		- throw new Error(`Unsupported Feishu action: "${String(ctx.action)}"`);
	`1061`	+ throw new Error(`Unsupported Feishu action: "${ctx.action}"`);
`1062`	`1062`	`},`
`1063`	`1063`	`},`
`1064`	`1064`	`bindings: {`
Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ function parseFeishuMessageItem(`
`276`	`276`	`senderType: item.sender?.sender_type,`
`277`	`277`	`content: parseFeishuMessageContent(rawContent, msgType),`
`278`	`278`	`contentType: msgType,`
`279`		`- createTime: item.create_time ? parseInt(String(item.create_time), 10) : undefined,`
	`279`	`+ createTime: item.create_time ? parseInt(item.create_time, 10) : undefined,`
`280`	`280`	`threadId: item.thread_id \|\| undefined,`
`281`	`281`	`};`
`282`	`282`	`}`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ async function postFirecrawlJson<T>(`
`141`	`141`	`detail = errorBody.text;`
`142`	`142`	`}`
`143`	`143`	`}`
`144`		`- const safeDetail = wrapWebContent(String(detail).slice(0, 1_000), "web_fetch");`
	`144`	`+ const safeDetail = wrapWebContent(detail.slice(0, 1_000), "web_fetch");`
`145`	`145`	throw new Error(`${params.errorLabel} API error (${response.status}): ${safeDetail}`);
`146`	`146`	`}`
`147`	`147`	`return await parse(response);`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ export function createTlonSetupWizardBase(params: TlonSetupWizardBaseParams): Ch`
`99`	`99`	`placeholder: "https://your-ship-host",`
`100`	`100`	`currentValue: ({ cfg, accountId }) => resolveTlonAccount(cfg, accountId).url ?? undefined,`
`101`	`101`	`validate: ({ value }) => {`
`102`		`- const next = validateUrbitBaseUrl(String(value ?? ""));`
	`102`	`+ const next = validateUrbitBaseUrl(value ?? "");`
`103`	`103`	`if (!next.ok) {`
`104`	`104`	`return next.error;`
`105`	`105`	`}`