fix(discord): centralize retry status parsing

steipete · steipete · commit 2644f26a3514 · 2026-05-29T08:14:57.000-04:00
diff --git a/extensions/discord/src/retry.test.ts b/extensions/discord/src/retry.test.ts
@@ -30,6 +30,10 @@ describe("isRetryableDiscordTransientError", () => {
     ["408 status", Object.assign(new Error("request timeout"), { status: 408 })],
     ["502 status", Object.assign(new Error("bad gateway"), { status: 502 })],
     ["503 statusCode", Object.assign(new Error("service unavailable"), { statusCode: 503 })],
+    [
+      "signed string statusCode",
+      Object.assign(new Error("service unavailable"), { statusCode: "+503" }),
+    ],
     ["fetch failed", new TypeError("fetch failed")],
     ["ECONNRESET", Object.assign(new Error("socket hang up"), { code: "ECONNRESET" })],
     ["ETIMEDOUT cause", new Error("request failed", { cause: { code: "ETIMEDOUT" } })],
@@ -40,6 +44,7 @@ describe("isRetryableDiscordTransientError", () => {
 
   it.each([
     ["400 status", Object.assign(new Error("bad request"), { status: 400 })],
+    ["fractional status", Object.assign(new Error("upstream rejected request"), { status: 500.5 })],
     ["403 status", Object.assign(new Error("missing permissions"), { statusCode: 403 })],
     ["unknown channel", new Error("Unknown Channel")],
     ["plain string", "fetch failed"],
diff --git a/extensions/discord/src/retry.ts b/extensions/discord/src/retry.ts
@@ -4,6 +4,7 @@ import {
   formatErrorMessage,
   readErrorName,
 } from "openclaw/plugin-sdk/error-runtime";
+import { parseStrictNonNegativeInteger } from "openclaw/plugin-sdk/number-runtime";
 import {
   createRateLimitRetryRunner,
   type RetryConfig,
@@ -45,13 +46,7 @@ function readDiscordErrorStatus(err: unknown): number | undefined {
       : "statusCode" in err && err.statusCode !== undefined
         ? err.statusCode
         : undefined;
-  if (typeof raw === "number" && Number.isFinite(raw)) {
-    return raw;
-  }
-  if (typeof raw === "string" && /^\d+$/.test(raw)) {
-    return Number(raw);
-  }
-  return undefined;
+  return parseStrictNonNegativeInteger(raw);
 }
 
 export function isRetryableDiscordTransientError(err: unknown): boolean {
