fix(delivery): mark error=true when best-effort sends all error out

Kaspre · claude · Kaspre · commit 242d12b603d7 · 2026-05-08T23:36:29.000-04:00
Codex review (post-rebase round 2, 2026-05-08) caught that
`--deliver --best-effort --json` with all-payload onError failures
returns `deliveryStatus: { attempted: true, succeeded: false }` with
no error flag, indistinguishable from a zero-result/cancelled delivery.

When `hadPartialFailure` is set (onError fired) AND zero payloads
succeeded, propagate `error: true` to the status. Partial successes
(at least one delivered) still report `succeeded: "partial"` without
the error flag — the partial value itself signals errors occurred.

Extends the existing best-effort-onError-zero-result test to assert
the new error flag.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/agents/command/delivery.test.ts b/src/agents/command/delivery.test.ts
@@ -266,6 +266,10 @@ describe("normalizeAgentCommandReplyPayloads", () => {
     });
 
     expect(delivered.deliveryStatus?.succeeded).toBe(false);
+    // When best-effort delivery records onError(s) AND yields zero successful
+    // results, distinguish the all-errored case from a plain zero-result/
+    // cancelled delivery by setting error: true on the status.
+    expect(delivered.deliveryStatus?.error).toBe(true);
     expect(runtime.error).toHaveBeenCalledWith(expect.stringContaining("send failed"));
   });
 
diff --git a/src/agents/command/delivery.ts b/src/agents/command/delivery.ts
@@ -474,7 +474,9 @@ export async function deliverAgentCommandResult(params: {
     requested: true as const,
     attempted: deliveryAttempted,
     succeeded: deliverySucceeded,
-    ...(deliveryThrewError || (preDeliveryError && !deliverySucceeded)
+    ...(deliveryThrewError ||
+    (preDeliveryError && !deliverySucceeded) ||
+    (hadPartialFailure && deliverySucceeded === false)
       ? { error: true as const }
       : {}),
   };
