fix(delivery): treat internal artifacts as silent skips

obviyus · obviyus · commit 2272f504eb4b · 2026-06-08T15:50:08.000Z
diff --git a/extensions/telegram/src/bot-message-dispatch.test.ts b/extensions/telegram/src/bot-message-dispatch.test.ts
@@ -4660,6 +4660,22 @@ describe("dispatchTelegramMessage draft streaming", () => {
     expect(deliverReplies).not.toHaveBeenCalled();
   });
 
+  it("does not emit an empty-response fallback for internal artifact skips", async () => {
+    dispatchReplyWithBufferedBlockDispatcher.mockImplementation(async ({ dispatcherOptions }) => {
+      dispatcherOptions.onSkip?.({ text: "<channel|>" }, { kind: "final", reason: "silent" });
+      return { queuedFinal: false, counts: { block: 0, final: 0, tool: 0 } };
+    });
+
+    await dispatchWithContext({
+      context: createContext({
+        ctxPayload: createDirectSessionPayload(),
+      }),
+      streamMode: "off",
+    });
+
+    expect(deliverReplies).not.toHaveBeenCalled();
+  });
+
   it("does not emit a silent-reply fallback for no-response group turns", async () => {
     dispatchReplyWithBufferedBlockDispatcher.mockResolvedValue({
       queuedFinal: false,
diff --git a/src/auto-reply/reply/normalize-reply.ts b/src/auto-reply/reply/normalize-reply.ts
@@ -20,7 +20,7 @@ import {
   type ResponsePrefixContext,
 } from "./response-prefix-template.js";
 
-export type NormalizeReplySkipReason = "empty" | "silent" | "heartbeat" | "internalArtifact";
+export type NormalizeReplySkipReason = "empty" | "silent" | "heartbeat";
 
 export type NormalizeReplyOptions = {
   responsePrefix?: string;
@@ -98,10 +98,8 @@ export function normalizeReplyPayload(
     text = stripped.text;
   }
 
-  // Suppress standalone internal protocol artifacts (Codex/Harmony channel
-  // markers, reasoning directives) before they reach messaging channels. #88128
   if (text && isInternalFormattingArtifact(text) && !hasContent("")) {
-    opts.onSkip?.("internalArtifact");
+    opts.onSkip?.("silent");
     return null;
   }
 
diff --git a/src/auto-reply/reply/reply-utils.test.ts b/src/auto-reply/reply/reply-utils.test.ts
@@ -150,7 +150,7 @@ describe("normalizeReplyPayload", () => {
     expect(reply.channelData).toEqual(payload.channelData);
   });
 
-  it("records skip reasons for silent/empty/internal-artifact payloads", () => {
+  it("records skip reasons for silent, empty, and internal artifact payloads", () => {
     const cases = [
       { name: "silent", payload: { text: SILENT_REPLY_TOKEN }, reason: "silent" },
       {
@@ -162,17 +162,17 @@ describe("normalizeReplyPayload", () => {
       {
         name: "internalArtifact <channel|>",
         payload: { text: "<channel|>" },
-        reason: "internalArtifact",
+        reason: "silent",
       },
       {
         name: "internalArtifact set-thought",
         payload: { text: "set-thought <channel|>" },
-        reason: "internalArtifact",
+        reason: "silent",
       },
       {
         name: "internalArtifact box-drawing separator",
         payload: { text: "───" },
-        reason: "internalArtifact",
+        reason: "silent",
       },
     ] as const;
     for (const testCase of cases) {
diff --git a/src/auto-reply/tokens.test.ts b/src/auto-reply/tokens.test.ts
@@ -18,6 +18,9 @@ describe("isInternalFormattingArtifact", () => {
     expect(isInternalFormattingArtifact("<channel|answer>")).toBe(true);
     expect(isInternalFormattingArtifact("<lane|reasoning>")).toBe(true);
     expect(isInternalFormattingArtifact("<|>")).toBe(true);
+    expect(isInternalFormattingArtifact("<|channel|>")).toBe(true);
+    expect(isInternalFormattingArtifact("<|message|>")).toBe(true);
+    expect(isInternalFormattingArtifact("<|call|>")).toBe(true);
   });
 
   it("matches set-thought directives (#88128)", () => {
diff --git a/src/auto-reply/tokens.ts b/src/auto-reply/tokens.ts
@@ -6,23 +6,9 @@ export const HEARTBEAT_TOKEN = "HEARTBEAT_OK";
 /** Token that marks an auto-reply response as intentionally silent. */
 export const SILENT_REPLY_TOKEN = "NO_REPLY";
 
-// Narrow protocol-only matcher for internal streaming artifacts that LLM
-// providers (Codex/Harmony) emit as standalone fragments during response
-// generation. Only matches patterns that are never valid user-facing content.
-// Intentionally excludes generic markdown separators (---, ***, ___) and
-// XML-like tags (<tag>, </tag>) which could appear in legitimate replies.
 const HARMONY_CHANNEL_MARKER_RE = /^\s*(?:set-thought\s+)?<[\w]*\|[^>]*>\s*$/;
 const BOX_DRAWING_HR_ONLY_RE = /^\s*─{3,}\s*$/;
 
-/**
- * Returns true when text consists entirely of an internal runtime/protocol
- * artifact that must never be delivered to user-facing messaging channels.
- *
- * Scoped to observed Codex/Harmony markers only:
- * - `<channel|>`, `<word|value>` — provider channel routing markers
- * - `set-thought <channel|>` — reasoning lane transition directives
- * - `───` (box-drawing HR) — internal markdown renderer separator
- */
 export function isInternalFormattingArtifact(text: string | undefined): boolean {
   if (!text) {
     return false;
