fix: exclude DM participant lists from iMessage self-chat check

obviyus · obviyus · commit 1ee4a1606e9a · 2026-04-09T17:23:22.000+05:30
diff --git a/extensions/imessage/src/monitor/inbound-processing.ts b/extensions/imessage/src/monitor/inbound-processing.ts
@@ -207,15 +207,8 @@ export function resolveIMessageInboundDecision(params: {
   const chatIdentifierNormalized = normalizeIMessageHandle(chatIdentifier ?? "") || undefined;
   const destinationCallerIdNormalized =
     normalizeIMessageHandle(destinationCallerId ?? "") || undefined;
-  const chatParticipantHandles = new Set(
-    (params.message.participants ?? [])
-      .map((participant) => normalizeIMessageHandle(participant))
-      .filter((participant): participant is string => participant.length > 0),
-  );
   const matchesSelfChatDestination =
-    destinationCallerIdNormalized == null ||
-    destinationCallerIdNormalized === senderNormalized ||
-    chatParticipantHandles.has(destinationCallerIdNormalized);
+    destinationCallerIdNormalized == null || destinationCallerIdNormalized === senderNormalized;
   const isSelfChat =
     !isGroup &&
     chatIdentifierNormalized != null &&
diff --git a/extensions/imessage/src/monitor/self-chat-dedupe.test.ts b/extensions/imessage/src/monitor/self-chat-dedupe.test.ts
@@ -393,7 +393,7 @@ describe("self-chat is_from_me=true handling (Bruce Phase 2 fix)", () => {
     expect(decision.kind).toBe("dispatch");
   });
 
-  it("preserves self-chat when destination_caller_id is another local handle", () => {
+  it("drops DM false positives even when participant lists include the local handle", () => {
     const echoCache = createSentMessageCache();
     const selfChatCache = createSelfChatCache();
 
@@ -405,18 +405,18 @@ describe("self-chat is_from_me=true handling (Bruce Phase 2 fix)", () => {
           chat_identifier: "+15551234567",
           destination_caller_id: "me@icloud.com",
           participants: ["+15551234567", "me@icloud.com"],
-          text: "Hello from my other local handle",
+          text: "Hello from a normal DM row",
           is_from_me: true,
           is_group: false,
         },
-        messageText: "Hello from my other local handle",
-        bodyText: "Hello from my other local handle",
+        messageText: "Hello from a normal DM row",
+        bodyText: "Hello from a normal DM row",
         echoCache,
         selfChatCache,
       }),
     );
 
-    expect(decision.kind).toBe("dispatch");
+    expect(decision).toEqual({ kind: "drop", reason: "from me" });
   });
 
   it("drops agent reply echo in self-chat (is_from_me=true, echo cache text match)", () => {
