fix(browser): default non-finite chrome mcp click delays

steipete · steipete · commit 1e48ca4e3251 · 2026-05-29T00:42:37.000-04:00
diff --git a/extensions/browser/src/browser/chrome-mcp.test.ts b/extensions/browser/src/browser/chrome-mcp.test.ts
@@ -3,6 +3,7 @@ import os from "node:os";
 import path from "node:path";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import {
+  clickChromeMcpCoords,
   clickChromeMcpElement,
   buildChromeMcpArgs,
   decodeChromeMcpStderrTail,
@@ -509,6 +510,31 @@ describe("chrome MCP page parsing", () => {
     expect(result).toBe(123);
   });
 
+  it("defaults non-finite coordinate click delays before injecting the browser script", async () => {
+    const session = createFakeSession();
+    const callTool = vi.fn(async ({ name }: ToolCall) => {
+      if (name === "evaluate_script") {
+        return { content: [{ type: "text", text: "```json\nnull\n```" }] };
+      }
+      throw new Error(`unexpected tool ${name}`);
+    });
+    session.client.callTool = callTool as typeof session.client.callTool;
+    setChromeMcpSessionFactoryForTest(async () => session);
+
+    await clickChromeMcpCoords({
+      profileName: "chrome-live",
+      targetId: "1",
+      x: 10,
+      y: 20,
+      delayMs: Number.NaN,
+    });
+
+    const callToolMock = callTool as unknown as ToolCallMock;
+    const evaluateCall = callToolMock.mock.calls.find(([call]) => call.name === "evaluate_script");
+    const fn = evaluateCall?.[0].arguments?.function;
+    expect(typeof fn === "string" ? fn : "").toContain("const delayMs = 0;");
+  });
+
   it("does not cache an ephemeral availability probe before the next real attach", async () => {
     let factoryCalls = 0;
     const closeMocks: Array<ReturnType<typeof vi.fn>> = [];
diff --git a/extensions/browser/src/browser/chrome-mcp.ts b/extensions/browser/src/browser/chrome-mcp.ts
@@ -7,7 +7,10 @@ import { setTimeout as sleepTimeout } from "node:timers/promises";
 import { promisify } from "node:util";
 import { Client } from "@modelcontextprotocol/sdk/client/index.js";
 import { StdioClientTransport } from "@modelcontextprotocol/sdk/client/stdio.js";
-import { parseStrictPositiveInteger } from "openclaw/plugin-sdk/number-runtime";
+import {
+  parseStrictPositiveInteger,
+  resolveNonNegativeIntegerOption,
+} from "openclaw/plugin-sdk/number-runtime";
 import {
   normalizeOptionalString,
   readStringValue,
@@ -1320,7 +1323,7 @@ export async function clickChromeMcpCoords(params: {
   const pressedButtons = button === "middle" ? 4 : button === "right" ? 2 : 1;
   const x = JSON.stringify(params.x);
   const y = JSON.stringify(params.y);
-  const delayMs = JSON.stringify(Math.max(0, Math.floor(params.delayMs ?? 0)));
+  const delayMs = JSON.stringify(resolveNonNegativeIntegerOption(params.delayMs, 0));
   const doubleClick = params.doubleClick ? "true" : "false";
   await evaluateChromeMcpScript({
     profileName: params.profileName,
