test(macos): document legacy approval fallback

jesse-merhi · jesse-merhi · commit 1c73fa13ed71 · 2026-05-27T13:49:46.000+10:00
diff --git a/apps/macos/Sources/OpenClaw/ExecApprovalsSocket.swift b/apps/macos/Sources/OpenClaw/ExecApprovalsSocket.swift
@@ -67,6 +67,9 @@ struct ExecApprovalPromptRequest: Codable {
     }
 
     static func allowedDecisions(forAsk ask: String?) -> [ExecApprovalDecision] {
+        // Older payloads did not carry ask/allowedDecisions. Preserve their durable
+        // approval option; explicit ask=always and allowedDecisions payloads are the
+        // policy-carrying shapes that remove it.
         ask == ExecAsk.always.rawValue
             ? [.allowOnce, .deny]
             : [.allowOnce, .allowAlways, .deny]
diff --git a/apps/macos/Tests/OpenClawIPCTests/ExecApprovalPromptLayoutTests.swift b/apps/macos/Tests/OpenClawIPCTests/ExecApprovalPromptLayoutTests.swift
@@ -51,6 +51,35 @@ struct ExecApprovalPromptLayoutTests {
         #expect(decisions == [.allowOnce, .allowAlways, .deny])
     }
 
+    @Test func `legacy prompts keep durable approval when policy fields are omitted`() {
+        let decisions = ExecApprovalsPromptPresenter.allowedPromptDecisions(
+            ExecApprovalPromptRequest(
+                command: "/bin/sh -lc pwd",
+                cwd: "/Users/example/projects/openclaw",
+                host: "node",
+                security: "full",
+                agentId: "main",
+                resolvedPath: "/bin/sh",
+                sessionKey: "session-1"))
+
+        #expect(decisions == [.allowOnce, .allowAlways, .deny])
+    }
+
+    @Test func `unknown ask prompts keep legacy durable approval when decisions are omitted`() {
+        let decisions = ExecApprovalsPromptPresenter.allowedPromptDecisions(
+            ExecApprovalPromptRequest(
+                command: "/bin/sh -lc pwd",
+                cwd: "/Users/example/projects/openclaw",
+                host: "node",
+                security: "full",
+                ask: "unexpected",
+                agentId: "main",
+                resolvedPath: "/bin/sh",
+                sessionKey: "session-1"))
+
+        #expect(decisions == [.allowOnce, .allowAlways, .deny])
+    }
+
     @Test func `approval request decodes valid allowed decisions only`() throws {
         let data = """
             {

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,9 @@ struct ExecApprovalPromptRequest: Codable {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`static func allowedDecisions(forAsk ask: String?) -> [ExecApprovalDecision] {`
	`70`	`+ // Older payloads did not carry ask/allowedDecisions. Preserve their durable`
	`71`	`+ // approval option; explicit ask=always and allowedDecisions payloads are the`
	`72`	`+ // policy-carrying shapes that remove it.`
`70`	`73`	`ask == ExecAsk.always.rawValue`
`71`	`74`	`? [.allowOnce, .deny]`
`72`	`75`	`: [.allowOnce, .allowAlways, .deny]`