fix(exec): default to GBK encoding on Windows (#50519)

Yaohua-Leo · Yaohua-Leo · commit 13652a195546 · 2026-03-20T03:46:40.000+08:00
- On Windows, cmd.exe outputs in GBK/CP936 by default, not UTF-8 - Changed default encoding from UTF-8 to GBK for Windows platform - Added encoding option to allow override when needed - This fixes garbled Chinese characters in exec tool output on Windows Fixes #50519
diff --git a/src/process/exec.ts b/src/process/exec.ts
@@ -100,16 +100,21 @@ export function shouldSpawnWithShell(params: {
 export async function runExec(
   command: string,
   args: string[],
-  opts: number | { timeoutMs?: number; maxBuffer?: number; cwd?: string } = 10_000,
+  opts:
+    | number
+    | { timeoutMs?: number; maxBuffer?: number; cwd?: string; encoding?: BufferEncoding } = 10_000,
 ): Promise<{ stdout: string; stderr: string }> {
+  // On Windows, default to gbk encoding for cmd.exe output (CP936),
+  // otherwise use utf8. Allow override via opts.encoding.
+  const defaultEncoding: BufferEncoding = process.platform === "win32" ? "gbk" : "utf8";
   const options =
     typeof opts === "number"
-      ? { timeout: opts, encoding: "utf8" as const }
+      ? { timeout: opts, encoding: defaultEncoding }
       : {
           timeout: opts.timeoutMs,
           maxBuffer: opts.maxBuffer,
           cwd: opts.cwd,
-          encoding: "utf8" as const,
+          encoding: opts.encoding ?? defaultEncoding,
         };
   try {
     const argv = [command, ...args];
