fix: add comment for check ordering + sync skills-status eligibility

Mitsuyuki Osabe · Mitsuyuki Osabe · commit 12255f8cfca8 · 2026-03-20T10:25:10.000Z
- Add comment explaining why enabled: true is checked after isBundledSkillAllowed (Greptile review feedback). - Sync skills-status.ts eligibility with force-enable: when enabled: true, mark the skill as eligible in status reporting so CLI output matches runtime behavior (Codex review feedback). ✍️ Author: Claude Code with @carrotRakko (AI-written, human-approved)
diff --git a/src/agents/skills-status.ts b/src/agents/skills-status.ts
@@ -200,7 +200,8 @@ function buildSkillStatus(
       isEnvSatisfied,
       isConfigSatisfied,
     });
-  const eligible = !disabled && !blockedByAllowlist && requirementsSatisfied;
+  const forceEnabled = skillConfig?.enabled === true;
+  const eligible = !disabled && !blockedByAllowlist && (forceEnabled || requirementsSatisfied);
 
   return {
     name: entry.skill.name,
diff --git a/src/agents/skills/config.ts b/src/agents/skills/config.ts
@@ -84,6 +84,9 @@ export function shouldIncludeSkill(params: {
   if (!isBundledSkillAllowed(entry, allowBundled)) {
     return false;
   }
+  // enabled: true force-enables, bypassing runtime eligibility (bins, OS, etc.).
+  // Placed after isBundledSkillAllowed so allowBundled still gates bundled skills.
+  // enabled: false short-circuits before that check since the result is the same.
   if (skillConfig?.enabled === true) {
     return true;
   }

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,9 @@ export function shouldIncludeSkill(params: {`
`84`	`84`	`if (!isBundledSkillAllowed(entry, allowBundled)) {`
`85`	`85`	`return false;`
`86`	`86`	`}`
	`87`	`+ // enabled: true force-enables, bypassing runtime eligibility (bins, OS, etc.).`
	`88`	`+ // Placed after isBundledSkillAllowed so allowBundled still gates bundled skills.`
	`89`	`+ // enabled: false short-circuits before that check since the result is the same.`
`87`	`90`	`if (skillConfig?.enabled === true) {`
`88`	`91`	`return true;`
`89`	`92`	`}`