Skip to content

Commit 10c7f87

Browse files
Fix Codex image generation tool timeout
1 parent 9ebbb63 commit 10c7f87

4 files changed

Lines changed: 4 additions & 6 deletions

File tree

extensions/codex/src/app-server/run-attempt.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1903,7 +1903,7 @@ describe("runCodexAppServerAttempt", () => {
19031903
).toBe(180_000);
19041904
});
19051905

1906-
it("uses a media-safe default for Codex image generation dynamic tool calls", () => {
1906+
it("uses a 120 second default for Codex image generation dynamic tool calls", () => {
19071907
expect(
19081908
testing.resolveDynamicToolCallTimeoutMs({
19091909
call: {
@@ -1916,7 +1916,7 @@ describe("runCodexAppServerAttempt", () => {
19161916
},
19171917
config: undefined,
19181918
}),
1919-
).toBe(testing.CODEX_DYNAMIC_IMAGE_GENERATION_TOOL_TIMEOUT_MS);
1919+
).toBe(120_000);
19201920
});
19211921

19221922
it("uses the media image timeout for Codex image dynamic tool calls", () => {

extensions/codex/src/app-server/run-attempt.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4797,7 +4797,6 @@ function handleApprovalRequest(params: {
47974797
export const testing = {
47984798
CODEX_DYNAMIC_TOOL_TIMEOUT_MS,
47994799
CODEX_DYNAMIC_TOOL_MAX_TIMEOUT_MS,
4800-
CODEX_DYNAMIC_IMAGE_GENERATION_TOOL_TIMEOUT_MS,
48014800
CODEX_DYNAMIC_IMAGE_TOOL_TIMEOUT_MS,
48024801
CODEX_TURN_COMPLETION_IDLE_TIMEOUT_MS,
48034802
CODEX_TURN_TERMINAL_IDLE_TIMEOUT_MS,

extensions/codex/src/app-server/side-question.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,7 +1072,7 @@ describe("runCodexAppServerSideQuestion", () => {
10721072
expect(timeoutMs).toBe(123_456);
10731073
});
10741074

1075-
it("uses a media-safe default for side-thread image_generate calls", () => {
1075+
it("uses a 120 second default for side-thread image_generate calls", () => {
10761076
const timeoutMs = testing.resolveSideDynamicToolCallTimeoutMs({
10771077
call: {
10781078
threadId: "side-thread",
@@ -1083,7 +1083,7 @@ describe("runCodexAppServerSideQuestion", () => {
10831083
config: {} as never,
10841084
});
10851085

1086-
expect(timeoutMs).toBe(testing.CODEX_SIDE_DYNAMIC_IMAGE_GENERATION_TOOL_TIMEOUT_MS);
1086+
expect(timeoutMs).toBe(120_000);
10871087
});
10881088

10891089
it("cleans up notification handlers when side tool setup fails", async () => {

extensions/codex/src/app-server/side-question.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,6 @@ function clampSideDynamicToolTimeoutMs(timeoutMs: number): number {
715715
}
716716

717717
export const testing = {
718-
CODEX_SIDE_DYNAMIC_IMAGE_GENERATION_TOOL_TIMEOUT_MS,
719718
resolveSideDynamicToolCallTimeoutMs,
720719
} as const;
721720

0 commit comments

Comments
 (0)