fix(imessage): bound HEIC staging conversion

Homer · Homer · commit 0fac83f34f11 · 2026-05-13T08:41:50.000-04:00
diff --git a/extensions/imessage/src/monitor/media-staging.ts b/extensions/imessage/src/monitor/media-staging.ts
@@ -9,6 +9,9 @@ import type { IMessageAttachment } from "./types.js";
 
 const execFileAsync = promisify(execFile);
 
+const HEIC_CONVERSION_TIMEOUT_MS = 15_000;
+const HEIC_CONVERSION_MAX_BUFFER_BYTES = 64 * 1024;
+
 export type StagedIMessageAttachment = {
   path: string;
   contentType?: string;
@@ -76,19 +79,27 @@ async function convertHeicToJpegWithSips(sourcePath: string, maxBytes: number):
     extension: "jpg",
   });
   try {
-    await execFileAsync("sips", [
-      "-s",
-      "format",
-      "jpeg",
-      "-s",
-      "formatOptions",
-      "90",
-      "-Z",
-      "4096",
-      sourcePath,
-      "--out",
-      tempPath,
-    ]);
+    await execFileAsync(
+      "sips",
+      [
+        "-s",
+        "format",
+        "jpeg",
+        "-s",
+        "formatOptions",
+        "90",
+        "-Z",
+        "4096",
+        sourcePath,
+        "--out",
+        tempPath,
+      ],
+      {
+        timeout: HEIC_CONVERSION_TIMEOUT_MS,
+        maxBuffer: HEIC_CONVERSION_MAX_BUFFER_BYTES,
+        killSignal: "SIGKILL",
+      },
+    );
     const stat = await fs.stat(tempPath);
     if (stat.size > maxBytes) {
       throw new Error(`converted media exceeds ${Math.round(maxBytes / (1024 * 1024))}MB limit`);
diff --git a/src/cron/delivery.test.ts b/src/cron/delivery.test.ts
@@ -170,7 +170,7 @@ describe("resolveCronDeliveryPlan", () => {
     }
   });
 
-  it("does not treat channel-owned service prefixes as provider selection", () => {
+  it("uses iMessage target prefixes as provider selection", () => {
     setCronDeliveryTestRegistry([
       {
         pluginId: "imessage",
@@ -189,7 +189,7 @@ describe("resolveCronDeliveryPlan", () => {
       }),
     );
     expect(plan.mode).toBe("announce");
-    expect(plan.channel).toBe("last");
+    expect(plan.channel).toBe("imessage");
     expect(plan.to).toBe("imessage:+15551234567");
   });
 });
diff --git a/src/infra/outbound/channel-target-prefix.ts b/src/infra/outbound/channel-target-prefix.ts
@@ -3,22 +3,11 @@ import { normalizeOptionalLowercaseString } from "../../shared/string-coerce.js"
 import { normalizeMessageChannel } from "../../utils/message-channel-core.js";
 
 const TARGET_KIND_PREFIXES = new Set([
-  "auto",
   "channel",
-  "chat",
-  "chat_guid",
-  "chat_identifier",
-  "chat_id",
-  "chatguid",
-  "chatid",
-  "chatident",
   "conversation",
   "dm",
   "group",
-  "guid",
-  "imessage",
   "room",
-  "sms",
   "thread",
   "user",
 ]);
