fix: handle unsupported Codex dynamic tool output

shakkernerd · shakkernerd · commit 0f291319fd96 · 2026-06-08T15:41:13.000+01:00
diff --git a/extensions/codex/src/app-server/run-attempt.test.ts b/extensions/codex/src/app-server/run-attempt.test.ts
@@ -1239,6 +1239,7 @@ describe("runCodexAppServerAttempt", () => {
       contentItems: [
         { type: "inputText", text: `lookup result: ${rawToolSecret}` },
         { type: "inputImage", imageUrl: "data:image/png;base64,abc" },
+        { type: "unsupportedCodexOutput", imageUrl: "data:image/png;base64,ignored" },
       ],
     });
     const content = result.content as Array<{ text?: string; type?: string; url?: string }>;
@@ -1249,6 +1250,10 @@ describe("runCodexAppServerAttempt", () => {
     expect(content[0]?.text).toContain("lookup result:");
     expect(content[0]?.text).not.toContain(rawToolSecret);
     expect(content[1]).toEqual({ type: "image", url: "data:image/png;base64,abc" });
+    expect(content[2]).toEqual({
+      type: "text",
+      text: "[Unsupported Codex dynamic tool output: unsupportedCodexOutput]",
+    });
     expect(JSON.stringify(result)).not.toContain(rawToolSecret);
   });
 
diff --git a/extensions/codex/src/app-server/run-attempt.ts b/extensions/codex/src/app-server/run-attempt.ts
@@ -331,12 +331,19 @@ function toTranscriptToolResultContentItem(item: unknown): Record<string, unknow
   if (record.type === "inputText") {
     return { type: "text", text: typeof record.text === "string" ? record.text : "" };
   }
-  if (record.type === "inputImage" || typeof record.imageUrl === "string") {
+  if (record.type === "inputImage") {
     return typeof record.imageUrl === "string"
       ? { type: "image", url: record.imageUrl }
-      : { type: "text", text: "" };
+      : { type: "text", text: formatUnsupportedCodexDynamicToolOutput(record.type) };
   }
-  return { type: "text", text: "" };
+  return { type: "text", text: formatUnsupportedCodexDynamicToolOutput(record.type) };
+}
+
+function formatUnsupportedCodexDynamicToolOutput(type: unknown): string {
+  const rawType = typeof type === "string" ? type.replace(/\s+/g, " ").trim() : "";
+  const label = rawType ? rawType.slice(0, 80) : "unknown";
+  const suffix = rawType.length > 80 ? "..." : "";
+  return `[Unsupported Codex dynamic tool output: ${label}${suffix}]`;
 }
 
 type CodexAgentEndHookParams = Parameters<typeof runAgentHarnessAgentEndHook>[0];
