fix: keep session lock teardown comment lean

steipete · steipete · commit 0f0787a5d2d1 · 2026-05-25T13:43:53.000+01:00
diff --git a/src/agents/pi-embedded-runner/run/attempt.session-lock.ts b/src/agents/pi-embedded-runner/run/attempt.session-lock.ts
@@ -630,12 +630,6 @@ export type EmbeddedAttemptSessionLockController = {
   ): Promise<T>;
   acquireForCleanup(params?: { session?: unknown }): Promise<SessionLock>;
   hasSessionTakeover(): boolean;
-  /**
-   * Force-release the eagerly-held session lock if it is still retained. Idempotent and safe
-   * to call from a run's outer `finally`: the happy path hands the lock to `acquireForCleanup`
-   * (so this is a no-op), but an exception on the post-prompt path can skip cleanup entirely,
-   * which would otherwise leak the lock to the live process until the watchdog reclaims it.
-   */
   dispose(): Promise<void>;
 };
 
diff --git a/src/agents/pi-embedded-runner/run/attempt.ts b/src/agents/pi-embedded-runner/run/attempt.ts
@@ -1272,10 +1272,7 @@ export async function runEmbeddedAttempt(
     | undefined;
   let beforeAgentRunBlocked = false;
   let beforeAgentRunBlockedBy: string | undefined;
-  // Set once the session lock controller exists, so the outer finally can always release the
-  // eagerly-held session lock even when an exception on the post-prompt path skips the cleanup
-  // block below (#86014). The cleanup block hands the lock off on normal/aborted paths, so this
-  // is a no-op then.
+  // Releases the eager session lock if post-prompt code exits before cleanup.
   let releaseRetainedSessionLock: (() => Promise<void>) | undefined;
   try {
     const skillsSnapshotForRun =
@@ -5039,10 +5036,6 @@ export async function runEmbeddedAttempt(
       }
     }
   } finally {
-    // Guarantee the eagerly-held session write lock is released on every exit path. The cleanup
-    // block above hands it to acquireForCleanup on normal/aborted/timed-out runs (so this is a
-    // no-op then), but an exception thrown in post-prompt processing skips that block and would
-    // otherwise leak the lock to the live gateway process until the watchdog reclaims it (#86014).
     try {
       await releaseRetainedSessionLock?.();
     } catch (releaseErr) {
