fix(heartbeat): deliver origin-carrying events when no heartbeat target is configured

anagnorisis2peripeteia · shakkernerd · commit 0e3687c4ef11 · 2026-06-10T20:41:06.000+01:00
The wake path carries the originating session's delivery context onto
the system event, but resolveHeartbeatDeliveryTarget defaulted to
target "none" whenever agents.defaults.heartbeat was absent — the
woken turn ran and its reply was silently dropped. When no heartbeat
target is configured and the drained event explicitly carried a
deliverable origin turn source, resolve delivery to that origin; an
explicit target "none" still suppresses, and runs without an origin
turn source keep the previous default.
diff --git a/src/infra/outbound/targets.test.ts b/src/infra/outbound/targets.test.ts
@@ -493,6 +493,55 @@ describe("resolveSessionDeliveryTarget", () => {
     expect(resolved.to).toBe("room:ops:topic:1008013");
   });
 
+  it("delivers an origin-carrying event when no heartbeat target is configured", () => {
+    // A wake/cron event that explicitly carried its origin delivery context
+    // names its own destination; the reply must not be dropped just because
+    // the deployment never configured agents.defaults.heartbeat.
+    const resolved = resolveHeartbeatDeliveryTarget({
+      cfg: {},
+      entry: {
+        sessionId: "sess-origin-no-config",
+        updatedAt: 1,
+        lastChannel: "alpha",
+        lastTo: "chat:one",
+      },
+      turnSource: { channel: "alpha", to: "chat:one", threadId: "77" },
+    });
+    expect(resolved.channel).toBe("alpha");
+    expect(resolved.to).toBe("chat:one");
+    expect(resolved.threadId).toBe("77");
+  });
+
+  it("keeps an explicit target:none suppressing origin-carrying events", () => {
+    const resolved = resolveHeartbeatDeliveryTarget({
+      cfg: {},
+      entry: {
+        sessionId: "sess-origin-target-none",
+        updatedAt: 1,
+        lastChannel: "alpha",
+        lastTo: "chat:one",
+      },
+      heartbeat: { target: "none" },
+      turnSource: { channel: "alpha", to: "chat:one" },
+    });
+    expect(resolved.channel).toBe("none");
+    expect(resolved.reason).toBe("target-none");
+  });
+
+  it("stays suppressed with unset heartbeat config and no origin turn source", () => {
+    const resolved = resolveHeartbeatDeliveryTarget({
+      cfg: {},
+      entry: {
+        sessionId: "sess-no-config-no-origin",
+        updatedAt: 1,
+        lastChannel: "alpha",
+        lastTo: "chat:one",
+      },
+    });
+    expect(resolved.channel).toBe("none");
+    expect(resolved.reason).toBe("target-none");
+  });
+
   const resolveHeartbeatTarget = (entry: SessionEntry, directPolicy?: "allow" | "block") =>
     resolveHeartbeatDeliveryTarget({
       cfg: {},
diff --git a/src/infra/outbound/targets.ts b/src/infra/outbound/targets.ts
@@ -111,6 +111,18 @@ export function resolveHeartbeatDeliveryTarget(params: {
     if (normalized) {
       target = normalized;
     }
+  } else if (
+    rawTarget === undefined &&
+    params.turnSource?.to &&
+    params.turnSource.channel &&
+    isDeliverableMessageChannel(params.turnSource.channel)
+  ) {
+    // No heartbeat target configured, but this run drains an event that
+    // explicitly carried its origin delivery context (e.g. a cron wake from a
+    // channel thread/topic). The event named its destination, so deliver to it
+    // instead of silently dropping the reply. An explicit `target: "none"`
+    // still suppresses delivery (operator opt-out above takes precedence).
+    target = "last";
   }
 
   if (target === "none") {
