fix(doctor): wire process.env into plugin drift check and add regression test

zenglingbiao · zenglingbiao · commit 0d9ac32d8aa4 · 2026-06-06T20:08:40.000+08:00
The previous version passed ctx.env to noteWorkspaceStatus, but the
top-level doctor flow never sets env on the context, so drift
detection was unreachable in normal runs.

- Use ctx.env ?? process.env so drift detection works for normal runs
- Add regression test that seeds drifted install records and asserts
  doctor emits the Plugin version drift note
diff --git a/src/commands/doctor-workspace-status.test.ts b/src/commands/doctor-workspace-status.test.ts
@@ -16,6 +16,10 @@ const mocks = vi.hoisted(() => ({
   buildPluginCompatibilityWarnings: vi.fn(),
   listTaskFlowRecords: vi.fn<() => unknown[]>(() => []),
   listTasksForFlowId: vi.fn<(flowId: string) => unknown[]>((_flowId: string) => []),
+  loadInstalledPluginIndexInstallRecords: vi.fn<() => Promise<Record<string, unknown>>>(() =>
+    Promise.resolve({}),
+  ),
+  VERSION: "2026.6.1",
 }));
 
 vi.mock("../agents/agent-scope.js", () => ({
@@ -34,6 +38,15 @@ vi.mock("../plugins/status.js", () => ({
     mocks.buildPluginCompatibilityWarnings(...args),
 }));
 
+vi.mock("../plugins/installed-plugin-index-records.js", () => ({
+  loadInstalledPluginIndexInstallRecords: (...args: unknown[]) =>
+    mocks.loadInstalledPluginIndexInstallRecords(...args),
+}));
+
+vi.mock("../version.js", () => ({
+  VERSION: mocks.VERSION,
+}));
+
 vi.mock("../tasks/task-flow-runtime-internal.js", () => ({
   listTaskFlowRecords: () => mocks.listTaskFlowRecords(),
 }));
@@ -48,6 +61,7 @@ async function runNoteWorkspaceStatusForTest(
   opts?: {
     flows?: unknown[];
     tasksByFlowId?: (flowId: string) => unknown[];
+    env?: Record<string, string>;
   },
 ) {
   mocks.resolveDefaultAgentId.mockReturnValue("default");
@@ -66,7 +80,7 @@ async function runNoteWorkspaceStatusForTest(
   );
 
   const noteSpy = vi.spyOn(noteModule, "note").mockImplementation(() => {});
-  await noteWorkspaceStatus({});
+  await noteWorkspaceStatus({}, opts?.env ? { env: opts.env as NodeJS.ProcessEnv } : undefined);
   return noteSpy;
 }
 
@@ -236,4 +250,42 @@ describe("noteWorkspaceStatus", () => {
       noteSpy.mockRestore();
     }
   });
+
+  it("reports plugin version drift when an official plugin version mismatches the gateway", async () => {
+    mocks.loadInstalledPluginIndexInstallRecords.mockResolvedValue({
+      codex: {
+        source: "npm",
+        spec: "@openclaw/codex@latest",
+        resolvedName: "@openclaw/codex",
+        resolvedVersion: "2026.5.30-beta.1",
+      },
+    });
+
+    const noteSpy = await runNoteWorkspaceStatusForTest(
+      createPluginLoadResult({
+        plugins: [
+          createPluginRecord({
+            id: "codex",
+            name: "Codex",
+            status: "loaded",
+            format: "bundle",
+            bundleCapabilities: ["provider:codex"],
+          }),
+        ],
+      }),
+      [],
+      { env: { OPENCLAW_HOME: "/tmp/test-openclaw" } },
+    );
+    try {
+      const driftCalls = noteSpy.mock.calls.filter(([, title]) => title === "Plugin version drift");
+      expect(driftCalls).toHaveLength(1);
+      const [[body]] = driftCalls;
+      expect(body).toContain("not on gateway 2026.6.1");
+      expect(body).toContain("codex: 2026.5.30-beta.1 -> expected 2026.6.1");
+      expect(body).toContain("openclaw plugins update <plugin-id>");
+    } finally {
+      noteSpy.mockRestore();
+      mocks.loadInstalledPluginIndexInstallRecords.mockResolvedValue({});
+    }
+  });
 });
diff --git a/src/flows/doctor-health-contributions.ts b/src/flows/doctor-health-contributions.ts
@@ -728,7 +728,7 @@ async function runSystemdLingerHealth(ctx: DoctorHealthFlowContext): Promise<voi
 
 async function runWorkspaceStatusHealth(ctx: DoctorHealthFlowContext): Promise<void> {
   const { noteWorkspaceStatus } = await import("../commands/doctor-workspace-status.js");
-  await noteWorkspaceStatus(ctx.cfg, { env: ctx.env });
+  await noteWorkspaceStatus(ctx.cfg, { env: ctx.env ?? process.env });
 }
 
 async function runSkillsHealth(ctx: DoctorHealthFlowContext): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,7 @@ async function runSystemdLingerHealth(ctx: DoctorHealthFlowContext): Promise<voi`
`728`	`728`
`729`	`729`	`async function runWorkspaceStatusHealth(ctx: DoctorHealthFlowContext): Promise<void> {`
`730`	`730`	`const { noteWorkspaceStatus } = await import("../commands/doctor-workspace-status.js");`
`731`		`- await noteWorkspaceStatus(ctx.cfg, { env: ctx.env });`
	`731`	`+ await noteWorkspaceStatus(ctx.cfg, { env: ctx.env ?? process.env });`
`732`	`732`	`}`
`733`	`733`
`734`	`734`	`async function runSkillsHealth(ctx: DoctorHealthFlowContext): Promise<void> {`