fix(browser): cap node runtime timeouts

steipete · steipete · commit 040f14b641e6 · 2026-05-29T17:07:33.000-04:00
diff --git a/extensions/browser/src/sdk-node-runtime.test.ts b/extensions/browser/src/sdk-node-runtime.test.ts
@@ -0,0 +1,18 @@
+import { MAX_TIMER_TIMEOUT_MS } from "openclaw/plugin-sdk/number-runtime";
+import { describe, expect, it, vi } from "vitest";
+import { withTimeout } from "./sdk-node-runtime.js";
+
+describe("withTimeout", () => {
+  it("caps oversized timeouts before arming the abort timer", async () => {
+    const timeoutSpy = vi
+      .spyOn(globalThis, "setTimeout")
+      .mockReturnValue(1 as unknown as ReturnType<typeof setTimeout>);
+    vi.spyOn(globalThis, "clearTimeout").mockImplementation(() => undefined);
+
+    await expect(
+      withTimeout(async () => "ok", Number.MAX_SAFE_INTEGER, "browser request"),
+    ).resolves.toBe("ok");
+
+    expect(timeoutSpy).toHaveBeenCalledWith(expect.any(Function), MAX_TIMER_TIMEOUT_MS);
+  });
+});
diff --git a/extensions/browser/src/sdk-node-runtime.ts b/extensions/browser/src/sdk-node-runtime.ts
@@ -23,11 +23,10 @@ export {
   type LazyPluginServiceHandle,
 } from "openclaw/plugin-sdk/plugin-runtime";
 export { defaultRuntime } from "openclaw/plugin-sdk/runtime-env";
+import { clampTimerTimeoutMs } from "openclaw/plugin-sdk/number-runtime";
 
 function normalizeTimeoutMs(timeoutMs: number | undefined): number | undefined {
-  return typeof timeoutMs === "number" && Number.isFinite(timeoutMs)
-    ? Math.max(1, Math.floor(timeoutMs))
-    : undefined;
+  return clampTimerTimeoutMs(timeoutMs);
 }
 
 function createTimeoutAbortSignal(timeoutMs: number, label: string | undefined) {
@@ -38,7 +37,10 @@ function createTimeoutAbortSignal(timeoutMs: number, label: string | undefined)
   return { controller, error, timer };
 }
 
-function waitForAbort(signal: AbortSignal, fallback: Error): {
+function waitForAbort(
+  signal: AbortSignal,
+  fallback: Error,
+): {
   promise: Promise<never>;
   cleanup: () => void;
 } {
