fix(ui): split view type seams

vincentkoc · vincentkoc · commit 01058162bebb · 2026-04-10T09:24:48.000+01:00
diff --git a/ui/src/ui/chat-model-ref.ts b/ui/src/ui/chat-model-ref.ts
@@ -1,14 +1,6 @@
+import type { ChatModelOverride } from "./chat-model-ref.types.ts";
 import type { ModelCatalogEntry } from "./types.ts";
-
-export type ChatModelOverride =
-  | {
-      kind: "qualified";
-      value: string;
-    }
-  | {
-      kind: "raw";
-      value: string;
-    };
+export type { ChatModelOverride } from "./chat-model-ref.types.ts";
 
 export function buildQualifiedChatModelValue(model: string, provider?: string | null): string {
   const trimmedModel = model.trim();
diff --git a/ui/src/ui/chat-model-ref.types.ts b/ui/src/ui/chat-model-ref.types.ts
@@ -0,0 +1,9 @@
+export type ChatModelOverride =
+  | {
+      kind: "qualified";
+      value: string;
+    }
+  | {
+      kind: "raw";
+      value: string;
+    };
diff --git a/ui/src/ui/types.ts b/ui/src/ui/types.ts
@@ -321,7 +321,7 @@ export type GatewaySessionsDefaults = {
   contextTokens: number | null;
 };
 
-export type ChatModelOverride = import("./chat-model-ref.ts").ChatModelOverride;
+export type ChatModelOverride = import("./chat-model-ref.types.ts").ChatModelOverride;
 
 export type GatewayAgentRow = SharedGatewayAgentRow;
 
diff --git a/ui/src/ui/views/agents-panels-overview.ts b/ui/src/ui/views/agents-panels-overview.ts
@@ -15,7 +15,7 @@ import {
   resolveModelLabel,
   resolveModelPrimary,
 } from "./agents-utils.ts";
-import type { AgentsPanel } from "./agents.ts";
+import type { AgentsPanel } from "./agents.types.ts";
 
 export function renderAgentOverview(params: {
   agent: AgentsListResult["agents"][number];
diff --git a/ui/src/ui/views/agents-panels-status-files.ts b/ui/src/ui/views/agents-panels-status-files.ts
@@ -20,7 +20,7 @@ import type {
   CronStatus,
 } from "../types.ts";
 import { type AgentContext } from "./agents-utils.ts";
-import type { AgentsPanel } from "./agents.ts";
+import type { AgentsPanel } from "./agents.types.ts";
 import { resolveChannelExtras as resolveChannelExtrasFromConfig } from "./channel-config-extras.ts";
 
 function renderAgentContextCard(
diff --git a/ui/src/ui/views/agents.ts b/ui/src/ui/views/agents.ts
@@ -18,10 +18,10 @@ import {
   renderAgentChannels,
   renderAgentCron,
 } from "./agents-panels-status-files.ts";
+export type { AgentsPanel } from "./agents.types.ts";
 import { renderAgentTools, renderAgentSkills } from "./agents-panels-tools-skills.ts";
 import { agentBadgeText, buildAgentContext, normalizeAgentLabel } from "./agents-utils.ts";
-
-export type AgentsPanel = "overview" | "files" | "tools" | "skills" | "channels" | "cron";
+import type { AgentsPanel } from "./agents.types.ts";
 
 export type ConfigState = {
   form: Record<string, unknown> | null;
diff --git a/ui/src/ui/views/agents.types.ts b/ui/src/ui/views/agents.types.ts
@@ -0,0 +1 @@
+export type AgentsPanel = "overview" | "files" | "tools" | "skills" | "channels" | "cron";
diff --git a/ui/src/ui/views/nodes-exec-approvals.ts b/ui/src/ui/views/nodes-exec-approvals.ts
@@ -10,7 +10,7 @@ import {
   resolveNodeTargets,
   type NodeTargetOption,
 } from "./nodes-shared.ts";
-import type { NodesProps } from "./nodes.ts";
+import type { NodesProps } from "./nodes.types.ts";
 
 type ExecSecurity = "deny" | "allowlist" | "full";
 type ExecAsk = "off" | "on-miss" | "always";
diff --git a/ui/src/ui/views/nodes.ts b/ui/src/ui/views/nodes.ts
@@ -1,52 +1,12 @@
 import { html, nothing } from "lit";
 import { t } from "../../i18n/index.ts";
-import type {
-  DevicePairingList,
-  DeviceTokenSummary,
-  PairedDevice,
-  PendingDevice,
-} from "../controllers/devices.ts";
-import type { ExecApprovalsFile, ExecApprovalsSnapshot } from "../controllers/exec-approvals.ts";
+import type { DeviceTokenSummary, PairedDevice, PendingDevice } from "../controllers/devices.ts";
 import { formatRelativeTimestamp, formatList } from "../format.ts";
 import { normalizeOptionalString } from "../string-coerce.ts";
 import { renderExecApprovals, resolveExecApprovalsState } from "./nodes-exec-approvals.ts";
 import { resolveConfigAgents, resolveNodeTargets, type NodeTargetOption } from "./nodes-shared.ts";
-export type NodesProps = {
-  loading: boolean;
-  nodes: Array<Record<string, unknown>>;
-  devicesLoading: boolean;
-  devicesError: string | null;
-  devicesList: DevicePairingList | null;
-  configForm: Record<string, unknown> | null;
-  configLoading: boolean;
-  configSaving: boolean;
-  configDirty: boolean;
-  configFormMode: "form" | "raw";
-  execApprovalsLoading: boolean;
-  execApprovalsSaving: boolean;
-  execApprovalsDirty: boolean;
-  execApprovalsSnapshot: ExecApprovalsSnapshot | null;
-  execApprovalsForm: ExecApprovalsFile | null;
-  execApprovalsSelectedAgent: string | null;
-  execApprovalsTarget: "gateway" | "node";
-  execApprovalsTargetNodeId: string | null;
-  onRefresh: () => void;
-  onDevicesRefresh: () => void;
-  onDeviceApprove: (requestId: string) => void;
-  onDeviceReject: (requestId: string) => void;
-  onDeviceRotate: (deviceId: string, role: string, scopes?: string[]) => void;
-  onDeviceRevoke: (deviceId: string, role: string) => void;
-  onLoadConfig: () => void;
-  onLoadExecApprovals: () => void;
-  onBindDefault: (nodeId: string | null) => void;
-  onBindAgent: (agentIndex: number, nodeId: string | null) => void;
-  onSaveBindings: () => void;
-  onExecApprovalsTargetChange: (kind: "gateway" | "node", nodeId: string | null) => void;
-  onExecApprovalsSelectAgent: (agentId: string) => void;
-  onExecApprovalsPatch: (path: Array<string | number>, value: unknown) => void;
-  onExecApprovalsRemove: (path: Array<string | number>) => void;
-  onSaveExecApprovals: () => void;
-};
+export type { NodesProps } from "./nodes.types.ts";
+import type { NodesProps } from "./nodes.types.ts";
 
 export function renderNodes(props: NodesProps) {
   const bindingState = resolveBindingsState(props);
diff --git a/ui/src/ui/views/nodes.types.ts b/ui/src/ui/views/nodes.types.ts
@@ -0,0 +1,39 @@
+import type { DevicePairingList } from "../controllers/devices.ts";
+import type { ExecApprovalsFile, ExecApprovalsSnapshot } from "../controllers/exec-approvals.ts";
+
+export type NodesProps = {
+  loading: boolean;
+  nodes: Array<Record<string, unknown>>;
+  devicesLoading: boolean;
+  devicesError: string | null;
+  devicesList: DevicePairingList | null;
+  configForm: Record<string, unknown> | null;
+  configLoading: boolean;
+  configSaving: boolean;
+  configDirty: boolean;
+  configFormMode: "form" | "raw";
+  execApprovalsLoading: boolean;
+  execApprovalsSaving: boolean;
+  execApprovalsDirty: boolean;
+  execApprovalsSnapshot: ExecApprovalsSnapshot | null;
+  execApprovalsForm: ExecApprovalsFile | null;
+  execApprovalsSelectedAgent: string | null;
+  execApprovalsTarget: "gateway" | "node";
+  execApprovalsTargetNodeId: string | null;
+  onRefresh: () => void;
+  onDevicesRefresh: () => void;
+  onDeviceApprove: (requestId: string) => void;
+  onDeviceReject: (requestId: string) => void;
+  onDeviceRotate: (deviceId: string, role: string, scopes?: string[]) => void;
+  onDeviceRevoke: (deviceId: string, role: string) => void;
+  onLoadConfig: () => void;
+  onLoadExecApprovals: () => void;
+  onBindDefault: (nodeId: string | null) => void;
+  onBindAgent: (agentIndex: number, nodeId: string | null) => void;
+  onSaveBindings: () => void;
+  onExecApprovalsTargetChange: (kind: "gateway" | "node", nodeId: string | null) => void;
+  onExecApprovalsSelectAgent: (agentId: string) => void;
+  onExecApprovalsPatch: (path: Array<string | number>, value: unknown) => void;
+  onExecApprovalsRemove: (path: Array<string | number>) => void;
+  onSaveExecApprovals: () => void;
+};

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export type AgentsPanel = "overview" \| "files" \| "tools" \| "skills" \| "channels" \| "cron";`