Conversation
|
Landed in 806d1b0. I fixed lint, added Sites URL MIME validation, merged current main, and kept the changelog credit. Thanks @thewilloftheshadow. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0ee64d0d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case driveMimeGoogleSite: | ||
| return mimeHTML |
There was a problem hiding this comment.
Reject Google Sites in default Drive download path
When downloading a Google Site without --format, the code now defaults to text/html and proceeds to Files.Export, even though the same commit explicitly treats Sites exports as unsupported in driveExportMimeTypeForFormat. This makes gog drive download <siteId> fail later with a generic API error instead of the intended actionable message, and it creates inconsistent behavior between implicit/default and explicit format handling.
Useful? React with 👍 / 👎.
| if id == "" { | ||
| return input | ||
| } | ||
| return fmt.Sprintf("https://sites.google.com/d/%s/edit", id) |
There was a problem hiding this comment.
Avoid mangling non-editor Sites URLs in open auto mode
This branch assumes any sites.google.com input has a Drive ID, but normalizeGoogleID only extracts IDs from /d/<id>/... URLs and otherwise returns the original string. For published/classic Sites URLs (for example .../site/<name>/...), id becomes the full URL and this produces an invalid editor URL like https://sites.google.com/d/https://.../edit instead of preserving the input.
Useful? React with 👍 / 👎.
Summary
sitescommand group withlist,search,get, andurlcommands for New Google Sites.sitesas an auth service using Drive scopes, including readonly/drive-scope handling.Validation
PATH="/Users/shadow/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.0.darwin-arm64/bin:$PATH" make testPATH="/Users/shadow/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:/Users/shadow/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.26.0.darwin-arm64/bin:$PATH" make docs-check