refactor(googleapi): extract authenticatedTransport and add NewHTTPCl…#534
Closed
johnbenjaminlewis wants to merge 1 commit intoopenclaw:mainfrom
Closed
refactor(googleapi): extract authenticatedTransport and add NewHTTPCl…#534johnbenjaminlewis wants to merge 1 commit intoopenclaw:mainfrom
johnbenjaminlewis wants to merge 1 commit intoopenclaw:mainfrom
Conversation
…ient Factor out the OAuth transport setup from optionsForAccountScopes into a reusable authenticatedTransport helper. Expose NewHTTPClient so callers that need a raw *http.Client (e.g. for custom redirect policies) can get one without going through the google-api-go options layer.
This was referenced Apr 27, 2026
Collaborator
|
Landed on Kept the transport extraction/NewHTTPClient shape from the PR, applied it on top of the current auth subject-backfill changes, and preserved co-author credit. Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(googleapi): extract authenticatedTransport and add NewHTTPClient
Summary
optionsForAccountScopesinto a reusableauthenticatedTransporthelper, removing duplication between the existing google-api-go client path and callers that need a raw*http.ClientNewHTTPClient(ctx, service, email)for callers that need to set their own policies (e.g. customCheckRedirect) on the HTTP client rather than going throughoption.WithHTTPClientnewDocsServiceForTestto uset.Cleanupinstead of returning a manual close funcTest plan
TestNewHTTPClient_NoRedirectPolicyverifies the returned client has no redirect policy set (callers can add their own)TestOptionsForAccountScopes_NoClientTimeoutcontinues to pass, confirming no regression in the existing pathmake testpasses