refactor(docs): improve findTab error messages with available tab names#532
Closed
johnbenjaminlewis wants to merge 1 commit intoopenclaw:mainfrom
Closed
refactor(docs): improve findTab error messages with available tab names#532johnbenjaminlewis wants to merge 1 commit intoopenclaw:mainfrom
johnbenjaminlewis wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Return an error from findTab instead of nil, listing available tab titles when no match is found. This gives users actionable feedback instead of a bare "tab not found" message. Made-with: Cursor
This was referenced Apr 27, 2026
Collaborator
|
Landed directly on main as 922ca38 (with changelog entry in ee9b552). Thanks @johnbenjaminlewis. |
Collaborator
|
Closing as landed on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(docs): improve
findTaberror messages with available tab namesSummary
findTabnow resolves tabs by exact ID first, then by case-insensitive title match, so users can pass either a tab ID or a human-readable nametab not found: "Shopping List" (available: "Inventory", "Markets")) instead of a bare "tab not found" messagefindTabreturns(*docs.Tab, error)instead of*docs.Tabso callers get structured errorsdocs cat --tabanddocs structure --tab(viabuildParagraphMap)Test plan
TestDocsCat_TabNotFoundandTestBuildParagraphMap_TabNotFoundexercise the updated error paths