fix(docs): add TabId support to markdown replace and improve error logging#517
Closed
dinakars777 wants to merge 2 commits intoopenclaw:mainfrom
Closed
fix(docs): add TabId support to markdown replace and improve error logging#517dinakars777 wants to merge 2 commits intoopenclaw:mainfrom
dinakars777 wants to merge 2 commits intoopenclaw:mainfrom
Conversation
added 2 commits
April 20, 2026 22:52
… headers When updating a draft with --quote but without --reply-to-message-id, the existing draft's message ID was fetched but never used to set the In-Reply-To and References headers. This caused delivery failures on strict mail servers. Fixes openclaw#512
…gging - Add TabId to InsertTextRequest in replaceDocsMarkdownRange - Add TabsCriteria to cleanupDocsImagePlaceholders - Pass TabId through runMarkdown -> replaceDocsMarkdownRange - Add warning when using --format markdown with --tab-id (DeleteContentRange does not support tab targeting at API level) - Improve error messages to include match index on failure Fixes openclaw#494
Collaborator
|
Thanks for the PR. I reviewed this against current Two blockers:
Happy to review a rebased/split version, but this mixed patch is no longer a good landing unit. |
Collaborator
|
Closing per review above: mixed stale patch; needs a fresh focused Docs-tab PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #494
Bug
gog docs find-replace <docId> "find" "replace" --format markdownsilently does nothing when using a tab.Root Cause
The markdown replace path (
replaceDocsMarkdownRange) was missing TabId support:InsertTextRequestdid not have TabId setcleanupDocsImagePlaceholdersdid not use TabsCriteriaAdditionally,
DeleteContentRangeRequest.Rangedoes not support TabId in the Google Docs API - this is a fundamental limitation.Fix
InsertTextRequest.LocationinreplaceDocsMarkdownRangeReplaceAllTextincleanupDocsImagePlaceholdersrunMarkdown→replaceDocsMarkdownRange--format markdownwith--tab-id(explaining the DeleteContentRange limitation)Testing