Skip to content

fix(cli): generate native zsh completions#481

Closed
piiq wants to merge 1 commit intoopenclaw:mainfrom
piiq:codex/fix-zsh-completion-script
Closed

fix(cli): generate native zsh completions#481
piiq wants to merge 1 commit intoopenclaw:mainfrom
piiq:codex/fix-zsh-completion-script

Conversation

@piiq
Copy link
Copy Markdown
Contributor

@piiq piiq commented Mar 27, 2026

Summary

  • replace the zsh completion output with a native _gog zsh completer
  • keep the implementation small by calling gog __complete directly from zsh
  • update the existing completion test to expect the native zsh marker

Why

The current gog completion zsh output is a bash compatibility shim using bashcompinit, which is awkward in zsh and does not install as a normal native zsh completion script.

Validation

  • go test ./internal/cmd
  • go test ./...
  • go run ./cmd/gog completion zsh | sed -n '1,40p'

@steipete
Copy link
Copy Markdown
Collaborator

Thanks @piiq! Landed the native zsh completion fix on main in 4f5e474. I kept it focused on the __complete bridge and added coverage. Closing this PR as landed.

@steipete steipete closed this Apr 20, 2026
@piiq
Copy link
Copy Markdown
Contributor Author

piiq commented Apr 20, 2026

yay!

@piiq piiq deleted the codex/fix-zsh-completion-script branch April 20, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants