fix: use 8bit Content-Transfer-Encoding for non-ASCII text bodies#477
Closed
yeager wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix: use 8bit Content-Transfer-Encoding for non-ASCII text bodies#477yeager wants to merge 1 commit intoopenclaw:mainfrom
yeager wants to merge 1 commit intoopenclaw:mainfrom
Conversation
When the message body contains non-ASCII characters (e.g. UTF-8 text in Swedish, German, etc.), the MIME Content-Transfer-Encoding was incorrectly set to '7bit'. Per RFC 2045 §2.7, 7bit encoding must not contain octets with the high bit set. This could cause mail servers to mangle the message body or, in some cases, strip attachments from multipart/mixed messages. Fix: introduce transferEncodingForText() that returns '8bit' when the text contains non-ASCII bytes, and '7bit' otherwise. Applied to all text body parts: standalone, multipart/alternative, and inline parts within multipart/mixed (with attachments).
Collaborator
|
Thanks! Landed manually on main as 3d63ebc with regression coverage and a CHANGELOG thank-you. I kept plain text quoted-printable, and fixed the non-ASCII HTML path so it no longer declares 7bit. Closing this PR since the fix is now on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When sending emails with non-ASCII body text (e.g. Swedish, German) AND attachments, the MIME
Content-Transfer-Encodingheader was set to7bitfor text parts. Per RFC 2045 §2.7,7bitencoding must not contain octets with the high bit set.This caused some mail servers/clients to either mangle the message body or strip attachments from
multipart/mixedmessages.Fix
Introduce
transferEncodingForText()helper that:"7bit"for pure ASCII text (no change for English-only emails)"8bit"for text containing non-ASCII bytes (UTF-8)Applied to all text body emission paths:
multipart/alternativemultipart/mixed(emails with attachments)Testing
All existing tests pass. The change is backwards-compatible — ASCII-only emails continue to use
7bit.